Re: [PATCH] target/arm: mark SP_EL1 with ARM_CP_EL3_NO_EL2_KEEP

[Peter Maydell]

On Wed, 28 Sept 2022 at 15:56, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 9/27/22 05:00, Jerome Forissier wrote:
> > SP_EL1 must be kept when EL3 is present but EL2 is not. Therefore mark
> > it with ARM_CP_EL3_NO_EL2_KEEP.
> >
> > Fixes: 696ba3771894 ("target/arm: Handle cpreg registration for missing EL")
> > Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> This certainly looks right, as how else would EL3 set up EL1 as desired. I 
> suppose this
> error comes from a slight mis-read of R_RJFFP, in that SP_EL1 may be 
> considered
> "associated" with EL1 and not EL[23].

Oops. Applied to target-arm.next, and
Cc: qemu-stable@nongnu.org
since this bug made it into 7.1 :-(

thanks
-- PMM