[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 04/17] accel/tcg: Introduce probe_access_full
From: |
Alex Bennée |
Subject: |
Re: [PATCH v5 04/17] accel/tcg: Introduce probe_access_full |
Date: |
Thu, 29 Sep 2022 12:51:45 +0100 |
User-agent: |
mu4e 1.9.0; emacs 28.2.50 |
Richard Henderson <richard.henderson@linaro.org> writes:
> Add an interface to return the CPUTLBEntryFull struct
> that goes with the lookup. The result is not intended
> to be valid across multiple lookups, so the user must
> use the results immediately.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/exec/exec-all.h | 11 ++++++++++
> accel/tcg/cputlb.c | 47 +++++++++++++++++++++++++----------------
> 2 files changed, 40 insertions(+), 18 deletions(-)
>
> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
> index bcad607c4e..758cf6bcc7 100644
> --- a/include/exec/exec-all.h
> +++ b/include/exec/exec-all.h
> @@ -434,6 +434,17 @@ int probe_access_flags(CPUArchState *env, target_ulong
> addr,
> MMUAccessType access_type, int mmu_idx,
> bool nonfault, void **phost, uintptr_t retaddr);
>
> +#ifndef CONFIG_USER_ONLY
> +/**
> + * probe_access_full:
> + * Like probe_access_flags, except also return into @pfull.
> + */
That lifetime requirement on @pfull really should be documented here as
well as the commit message.
Otherwise:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
- [PATCH v5 00/17] tcg: CPUTLBEntryFull and TARGET_TB_PCREL, Richard Henderson, 2022/09/25
- [PATCH v5 01/17] accel/tcg: Rename CPUIOTLBEntry to CPUTLBEntryFull, Richard Henderson, 2022/09/25
- [PATCH v5 02/17] accel/tcg: Drop addr member from SavedIOTLB, Richard Henderson, 2022/09/25
- [PATCH v5 03/17] accel/tcg: Suppress auto-invalidate in probe_access_internal, Richard Henderson, 2022/09/25
- [PATCH v5 04/17] accel/tcg: Introduce probe_access_full, Richard Henderson, 2022/09/25
- Re: [PATCH v5 04/17] accel/tcg: Introduce probe_access_full,
Alex Bennée <=
- [PATCH v5 05/17] accel/tcg: Introduce tlb_set_page_full, Richard Henderson, 2022/09/25
- [PATCH v5 06/17] include/exec: Introduce TARGET_PAGE_ENTRY_EXTRA, Richard Henderson, 2022/09/25
- [PATCH v5 07/17] target/sparc: Use tlb_set_page_full, Richard Henderson, 2022/09/25
- [PATCH v5 08/17] accel/tcg: Move byte_swap from MemTxAttrs to CPUTLBEntryFull, Richard Henderson, 2022/09/25
- [PATCH v5 09/17] accel/tcg: Add force_aligned to CPUTLBEntryFull, Richard Henderson, 2022/09/25
- [PATCH v5 10/17] accel/tcg: Remove PageDesc code_bitmap, Richard Henderson, 2022/09/25