[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] hw/loongarch: Add memmap for LoongArch virt machine
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 1/3] hw/loongarch: Add memmap for LoongArch virt machine |
|
Date: |
Wed, 28 Sep 2022 19:25:39 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 |
On 9/26/22 23:12, Xiaojuan Yang wrote:
Using memmap table for loongarch virt machine type, this method
comes from arm/riscv architectures.
While being data driven is nice...
+ hwaddr base = ms->memmap[VIRT_ACPI_GED].base + ACPI_GED_EVT_SEL_LEN +
... these indexes are not really better than the constant they replace.
Perhaps delay this until you've more than one machinestate against which this can be
properly parameterized.
+static MemMapEntry virt_memmap[] = {
FWIW, this array could be const.
r~