qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 06/15] target/arm: ensure m-profile helpers set appropriat


From: Richard Henderson
Subject: Re: [PATCH v3 06/15] target/arm: ensure m-profile helpers set appropriate MemTxAttrs
Date: Wed, 28 Sep 2022 09:57:30 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 9/27/22 07:14, Alex Bennée wrote:
There are a number of helpers for M-profile that deal with CPU
initiated access to the vector and stack areas. While it is unlikely
these coincided with memory mapped IO devices it is not inconceivable.
Embedded targets tend to attract all sorts of interesting code and for
completeness we should tag the transaction appropriately.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
  target/arm/m_helper.c | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/target/arm/m_helper.c b/target/arm/m_helper.c
index 5ee4ee15b3..d244e9c1c5 100644
--- a/target/arm/m_helper.c
+++ b/target/arm/m_helper.c
@@ -184,7 +184,7 @@ static bool v7m_stack_write(ARMCPU *cpu, uint32_t addr, 
uint32_t value,
      CPUState *cs = CPU(cpu);
      CPUARMState *env = &cpu->env;
      MemTxResult txres;
-    GetPhysAddrResult res = {};
+    GetPhysAddrResult res = { .attrs = MEMTXATTRS_CPU(cs) };
      ARMMMUFaultInfo fi = {};
      bool secure = mmu_idx & ARM_MMU_IDX_M_S;
      int exc;

Surely this is redundant with the initialization by get_phys_page()?


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]