>> + warn_report_once("KVM: encounter a notify exit with %svalid
>> context in"
>> + " guest. It means there can be possible
>> misbehaves in"
>> + " guest, please have a look.",
>> + ctx_invalid ? "in" : "");
>
> The warning should be unconditional if the context is invalid.
>
In valid context case, the warning can also notify the admin that the
guest misbehaves. Is it necessary to remove it?
You can keep it, but it should be separated so that that invalid context case uses warn_report instead of warn_report_once.
Paolo
>> + object_class_property_add(oc, X86_MACHINE_NOTIFY_WINDOW, "uint32_t",
>
> uint32 (not uint32_t)
>
...
>> + x86_machine_get_notify_window,
>> + x86_machine_set_notify_window, NULL,
>> NULL);
>> + object_class_property_set_description(oc, X86_MACHINE_NOTIFY_WINDOW,
>> + "Set the notify window required by notify VM exit");
>
> "Clock cycles without an event window after which a notification VM exit
> occurs"
>
Will Fix it. Thanks a lot!
> Thanks,
>
> Paolo
>
> From a5cb704991cfcda19a33c622833b69a8f6928530 Mon Sep 17 00:00:00 2001
> From: Paolo Bonzini <pbonzini@redhat.com>
> Date: Tue, 27 Sep 2022 15:20:16 +0200
> Subject: [PATCH] kvm: allow target-specific accelerator properties
>
> Several hypervisor capabilities in KVM are target-specific. When exposed
> to QEMU users as accelerator properties (i.e. -accel kvm,prop=value), they
> should not be available for all targets.
>
> Add a hook for targets to add their own properties to -accel kvm; for
> now no such property is defined.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
> index 5acab1767f..f90c5cb285 100644
> --- a/accel/kvm/kvm-all.c
> +++ b/accel/kvm/kvm-all.c
> @@ -3737,6 +3737,8 @@ static void kvm_accel_class_init(ObjectClass *oc,
> void *data)
> NULL, NULL);
> object_class_property_set_description(oc, "dirty-ring-size",
> "Size of KVM dirty page ring buffer (default: 0, i.e. use
> bitmap)");
> +
> + kvm_arch_accel_class_init(oc);
> }
>
> static const TypeInfo kvm_accel_type = {
> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
> index efd6dee818..50868ebf60 100644
> --- a/include/sysemu/kvm.h
> +++ b/include/sysemu/kvm.h
> @@ -353,6 +353,8 @@ bool kvm_device_supported(int vmfd, uint64_t type);
>
> extern const KVMCapabilityInfo kvm_arch_required_capabilities[];
>
> +void kvm_arch_accel_class_init(ObjectClass *oc);
> +
> void kvm_arch_pre_run(CPUState *cpu, struct kvm_run *run);
> MemTxAttrs kvm_arch_post_run(CPUState *cpu, struct kvm_run *run);
>
> diff --git a/target/arm/kvm.c b/target/arm/kvm.c
> index e5c1bd50d2..d21603cf28 100644
> --- a/target/arm/kvm.c
> +++ b/target/arm/kvm.c
> @@ -1056,3 +1056,7 @@ bool kvm_arch_cpu_check_are_resettable(void)
> {
> return true;
> }
> +
> +void kvm_arch_accel_class_init(ObjectClass *oc)
> +{
> +}
> diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
> index 21880836a6..22b3b37193 100644
> --- a/target/i386/kvm/kvm.c
> +++ b/target/i386/kvm/kvm.c
> @@ -5472,3 +5472,7 @@ void kvm_request_xsave_components(X86CPU *cpu,
> uint64_t mask)
> mask &= ~BIT_ULL(bit);
> }
> }
> +
> +void kvm_arch_accel_class_init(ObjectClass *oc)
> +{
> +}
> diff --git a/target/mips/kvm.c b/target/mips/kvm.c
> index caf70decd2..bcb8e06b2c 100644
> --- a/target/mips/kvm.c
> +++ b/target/mips/kvm.c
> @@ -1294,3 +1294,7 @@ bool kvm_arch_cpu_check_are_resettable(void)
> {
> return true;
> }
> +
> +void kvm_arch_accel_class_init(ObjectClass *oc)
> +{
> +}
> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
> index 466d0d2f4c..7c25348b7b 100644
> --- a/target/ppc/kvm.c
> +++ b/target/ppc/kvm.c
> @@ -2966,3 +2966,7 @@ bool kvm_arch_cpu_check_are_resettable(void)
> {
> return true;
> }
> +
> +void kvm_arch_accel_class_init(ObjectClass *oc)
> +{
> +}
> diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c
> index 70b4cff06f..30f21453d6 100644
> --- a/target/riscv/kvm.c
> +++ b/target/riscv/kvm.c
> @@ -532,3 +532,7 @@ bool kvm_arch_cpu_check_are_resettable(void)
> {
> return true;
> }
> +
> +void kvm_arch_accel_class_init(ObjectClass *oc)
> +{
> +}
> diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c
> index 7bd8db0e7b..840af34576 100644
> --- a/target/s390x/kvm/kvm.c
> +++ b/target/s390x/kvm/kvm.c
> @@ -2574,3 +2574,7 @@ bool kvm_arch_cpu_check_are_resettable(void)
> {
> return true;
> }
> +
> +void kvm_arch_accel_class_init(ObjectClass *oc)
> +{
> +}
>