[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 18/54] tests/qtest: vhost-user-test: Avoid using hardcoded
From: |
Marc-André Lureau |
Subject: |
Re: [PATCH v4 18/54] tests/qtest: vhost-user-test: Avoid using hardcoded /tmp |
Date: |
Tue, 27 Sep 2022 18:28:17 +0400 |
On Tue, Sep 27, 2022 at 3:07 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Bin Meng <bin.meng@windriver.com>
>
> This case was written to use hardcoded /tmp directory for temporary
> files. Update to use g_dir_make_tmp() for a portable implementation.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
> Changes in v4:
> - Update error reporting
>
> Changes in v3:
> - Split to a separate patch
> - Ensure g_autofree variable is initialized
>
> tests/qtest/vhost-user-test.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
> index d7d6cfc9bd..84498941a6 100644
> --- a/tests/qtest/vhost-user-test.c
> +++ b/tests/qtest/vhost-user-test.c
> @@ -482,8 +482,8 @@ static TestServer *test_server_new(const gchar *name,
> struct vhost_user_ops *ops)
> {
> TestServer *server = g_new0(TestServer, 1);
> - char template[] = "/tmp/vhost-test-XXXXXX";
> - const char *tmpfs;
> + g_autofree const char *tmpfs = NULL;
> + GError *err = NULL;
>
> server->context = g_main_context_new();
> server->loop = g_main_loop_new(server->context, FALSE);
> @@ -491,9 +491,11 @@ static TestServer *test_server_new(const gchar *name,
> /* run the main loop thread so the chardev may operate */
> server->thread = g_thread_new(NULL, thread_function, server->loop);
>
> - tmpfs = g_mkdtemp(template);
> + tmpfs = g_dir_make_tmp("vhost-test-XXXXXX", &err);
> if (!tmpfs) {
> - g_test_message("g_mkdtemp on path (%s): %s", template,
> strerror(errno));
> + g_test_message("g_dir_make_tmp on path (%s): %s", tmpfs,
> + err->message);
> + g_error_free(err);
You missed the opportunity to use g_autoptr(GError), ok anyway
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> }
> g_assert(tmpfs);
>
> --
> 2.34.1
>
- [PATCH v4 25/54] block/vvfat: Unify the mkdir() call, (continued)
- [PATCH v4 25/54] block/vvfat: Unify the mkdir() call, Bin Meng, 2022/09/27
- [PATCH v4 24/54] tests: vhost-user-bridge: Avoid using hardcoded /tmp, Bin Meng, 2022/09/27
- [PATCH v4 15/54] tests/qtest: pflash-cfi02-test: Avoid using hardcoded /tmp, Bin Meng, 2022/09/27
- [PATCH v4 16/54] tests/qtest: qmp-test: Avoid using hardcoded /tmp, Bin Meng, 2022/09/27
- [PATCH v4 11/54] tests/qtest: virtio_blk_fuzz: Avoid using hardcoded /tmp, Bin Meng, 2022/09/27
- [PATCH v4 23/54] tests/unit: test-qga: Avoid using hardcoded /tmp, Bin Meng, 2022/09/27
- [PATCH v4 18/54] tests/qtest: vhost-user-test: Avoid using hardcoded /tmp, Bin Meng, 2022/09/27
- Re: [PATCH v4 18/54] tests/qtest: vhost-user-test: Avoid using hardcoded /tmp,
Marc-André Lureau <=
- [PATCH v4 27/54] hw/usb: dev-mtp: Use g_mkdir(), Bin Meng, 2022/09/27
- [PATCH v4 29/54] tests/qtest: Build test-filter-{mirror, redirector} cases for posix only, Bin Meng, 2022/09/27
- [PATCH v4 33/54] tests/qtest: Use send/recv for socket communication, Bin Meng, 2022/09/27
- [PATCH v4 31/54] accel/qtest: Implement a portable qtest accelerator, Bin Meng, 2022/09/27
- [PATCH v4 26/54] fsdev/virtfs-proxy-helper: Use g_mkdir(), Bin Meng, 2022/09/27
- [PATCH v4 28/54] tests/qtest: Skip running virtio-net-test cases that require socketpair() for win32, Bin Meng, 2022/09/27
- [PATCH v4 30/54] tests/qtest: qmp-test: Skip running test_qmp_oob for win32, Bin Meng, 2022/09/27