[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 06/54] tests/qtest: aspeed_smc-test: Avoid using hardcoded

From: Cédric Le Goater
Subject: Re: [PATCH v3 06/54] tests/qtest: aspeed_smc-test: Avoid using hardcoded /tmp
Date: Sun, 25 Sep 2022 18:20:49 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0

On 9/25/22 13:29, Bin Meng wrote:
From: Bin Meng <bin.meng@windriver.com>

This case was written to use hardcoded /tmp directory for temporary
files. Update to use g_file_open_tmp() for a portable implementation.

Signed-off-by: Bin Meng <bin.meng@windriver.com>

Reviewed-by: Cédric Le Goater <clg@kaod.org>




Changes in v3:
- Split to a separate patch
- Ensure g_autofree variable is initialized

  tests/qtest/aspeed_smc-test.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/qtest/aspeed_smc-test.c b/tests/qtest/aspeed_smc-test.c
index 05ce941566..c713a3700b 100644
--- a/tests/qtest/aspeed_smc-test.c
+++ b/tests/qtest/aspeed_smc-test.c
@@ -608,16 +608,15 @@ static void test_write_block_protect_bottom_bit(void)
-static char tmp_path[] = "/tmp/qtest.m25p80.XXXXXX";
  int main(int argc, char **argv)
+    g_autofree char *tmp_path = NULL;
      int ret;
      int fd;
g_test_init(&argc, &argv, NULL); - fd = mkstemp(tmp_path);
+    fd = g_file_open_tmp("qtest.m25p80.XXXXXX", &tmp_path, NULL);
      g_assert(fd >= 0);
      ret = ftruncate(fd, FLASH_SIZE);
      g_assert(ret == 0);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]