Re: [PATCH v1 8/9] gdbstub: move breakpoint logic to accel ops

[Richard Henderson]

On 9/22/22 14:58, Alex Bennée wrote:
> As HW virtualization requires specific support to handle breakpoints
> lets push out special casing out of the core gdbstub code and into
> AccelOpsClass. This will make it easier to add other accelerator
> support and reduces some of the stub shenanigans.
>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> Cc: Mads Ynddal<mads@ynddal.dk>
> ---
>   accel/kvm/kvm-cpus.h       |   3 +
>   gdbstub/internals.h        |  16 +++++
>   include/sysemu/accel-ops.h |   6 ++
>   include/sysemu/cpus.h      |   3 +
>   include/sysemu/kvm.h       |   5 --
>   accel/kvm/kvm-accel-ops.c  |   8 +++
>   accel/kvm/kvm-all.c        |  24 +------
>   accel/stubs/kvm-stub.c     |  16 -----
>   accel/tcg/tcg-accel-ops.c  |  92 +++++++++++++++++++++++++++
>   gdbstub/gdbstub.c          | 127 +++----------------------------------
>   gdbstub/softmmu.c          |  42 ++++++++++++
>   gdbstub/user.c             |  62 ++++++++++++++++++
>   softmmu/cpus.c             |   7 ++
>   gdbstub/meson.build        |   8 +++
>   14 files changed, 259 insertions(+), 160 deletions(-)
>   create mode 100644 gdbstub/internals.h
>   create mode 100644 gdbstub/softmmu.c
>   create mode 100644 gdbstub/user.c

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~