Re: [PATCH v2 22/37] target/i386: reimplement 0x0f 0x78-0x7f, add AVX

[Richard Henderson]

On 9/20/22 17:24, Paolo Bonzini wrote:
> +static void decode_0F78(DisasContext *s, CPUX86State *env, X86OpEntry *entry, 
> uint8_t *b)
> +{
> +    static const X86OpEntry opcodes_0F78[4] = {
> +        {},
> +        X86_OP_ENTRY3(EXTRQ_i,       V,x, None,None, I,w,  cpuid(SSE4A)),
> +        {},
> +        X86_OP_ENTRY3(INSERTQ_i,     V,x, U,x, I,w,        cpuid(SSE4A)),
> +    };
> +    *entry = *decode_by_prefix(s, opcodes_0F78);
> +}

These are sse4a.

> +static void decode_0F79(DisasContext *s, CPUX86State *env, X86OpEntry *entry, 
> uint8_t *b)
> +{
> +    if (s->prefix & PREFIX_REPNZ) {
> +        entry->gen = gen_INSERTQ_r;
> +    } else if (s->prefix & PREFIX_DATA) {
> +        entry->gen = gen_EXTRQ_r;
> +    } else {
> +        entry->gen = NULL;
> +    };
> +}
...
> +    [0x79] = X86_OP_GROUP2(0F79,       V,x, U,x,       cpuid(SSE4A)),

These are not -- they're AMD New Media.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~