On Fri, Sep 23, 2022 at 12:47 PM David Hildenbrand <david@redhat.com> wrote:
You must be fortunate if "one afternoon" is not a significant time
investment. For me it is a significant investment.
For me too, to say the least of the multiple afternoons I've spent on
this patch set. Getting back to technical content:
and sort out the remaining issues. I thought we (Thomas included) had an
agreement that that's the way we are going to do it. Apparently I was wrong.
Most probably I lived in the kernel space too long such that we don't
rush something upstream. For that reason *I* sent out a patch with
Here I am, getting told by Thomas that we now do it differently now.
What I really tried to express here is: if Thomas wants to commit things
differently now, maybe he can just separate the cleanup parts. I really
*don't want* to send out a multi-patch series to cleanup individual
parts -- that takes significantly more time. Especially not if something
is not committed yet.
To recap what's been fixed in your v8.1, versus what's been refactored
out of style preference:
1) It handles the machine versioning.
2) It throws an exception on length alignment in KIMD mode:
+ /* KIMD: length has to be properly aligned. */
+ if (type == S390_FEAT_TYPE_KIMD && !QEMU_IS_ALIGNED(len, 128)) {
+ tcg_s390_program_interrupt(env, PGM_SPECIFICATION, ra);
+ }
3) It asserts if type is neither KIMD vs KLMD, with:
+ g_assert(type == S390_FEAT_TYPE_KIMD || type == S390_FEAT_TYPE_KLMD);