[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/7] configure: fix misc shellcheck warnings
From: |
Peter Maydell |
Subject: |
Re: [PATCH 0/7] configure: fix misc shellcheck warnings |
Date: |
Thu, 22 Sep 2022 15:15:47 +0100 |
On Thu, 25 Aug 2022 at 16:07, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> Currently if you run shellcheck on our configure script it
> generates a ton of warnings. This patchset fixes some of the
> easier ones. I wasn't aiming for completeness or consistency;
> I just wanted to zap some of the ones where the fix is clear
> and didn't take long to write and is hopefully easy to review.
> We can always come back and take another swing at it later.
>
> thanks
> -- PMM
>
> Peter Maydell (7):
> configure: Remove unused python_version variable
> configure: Remove unused meson_args variable
> configure: Add missing quoting for some easy cases
> configure: Add './' on front of glob of */config-devices.mak.d
> configure: Remove use of backtick `...` syntax
> configure: Check mkdir result directly, not via $?
> configure: Avoid use of 'local' as it is non-POSIX
Thanks to all for the review; I'll take these via target-arm.next
unless anybody has a preference otherwise.
-- PMM
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 0/7] configure: fix misc shellcheck warnings,
Peter Maydell <=