[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/4] x86: return modified setup_data only if read as memor
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH v5 1/4] x86: return modified setup_data only if read as memory, not as file |
Date: |
Thu, 22 Sep 2022 09:26:28 +0200 |
On Wed, 21 Sep 2022 11:31:31 +0200, Jason A. Donenfeld wrote:
> If setup_data is being read into a specific memory location, then
> generally the setup_data address parameter is read first, so that the
> caller knows where to read it into. In that case, we should return
> setup_data containing the absolute addresses that are hard coded and
> determined a priori. This is the case when kernels are loaded by BIOS,
> for example. In contrast, when setup_data is read as a file, then we
> shouldn't modify setup_data, since the absolute address will be wrong by
> definition. This is the case when OVMF loads the image.
>
> [...]
Applied, thanks!
[1/4] x86: return modified setup_data only if read as memory, not as file
commit: 7e660efb4d2af17582588bcdc4af7d28040feda6
[2/4] x86: use typedef for SetupData struct
commit: 1127a29a33f975943d89fc36ab934ad37810e4b7
[3/4] x86: reinitialize RNG seed on system reboot
commit: e997fc36def502dc3e9da915816083f086dff8f2
[4/4] x86: re-enable rng seeding via SetupData
commit: a731bae726f2b3168dea9d5137cb7e47444448eb
Best regards,
--
Paolo Bonzini <pbonzini@redhat.com>