Re: [PATCH 1/8] qtest: "-display none" is set in qtest_init()

[Thomas Huth]

On 02/09/2022 18.51, Juan Quintela wrote:
> So we don't need to set anywhere else.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
...
> diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuzz.c
> index afc1d20355..94b00288d9 100644
> --- a/tests/qtest/fuzz/generic_fuzz.c
> +++ b/tests/qtest/fuzz/generic_fuzz.c
> @@ -981,8 +981,7 @@ static GString *generic_fuzz_cmdline(FuzzTarget *t)
>       if (!getenv("QEMU_FUZZ_ARGS")) {
>           usage();
>       }
> -    g_string_append_printf(cmd_line, " -display none \
> -                                      -machine accel=qtest, \
> +    g_string_append_printf(cmd_line, " -machine accel=qtest, \
>                                         -m 512M %s ", getenv("QEMU_FUZZ_ARGS"));
>       return cmd_line;
>   }
> diff --git a/tests/qtest/fuzz/i440fx_fuzz.c b/tests/qtest/fuzz/i440fx_fuzz.c
> index b17fc725df..f2c729493f 100644
> --- a/tests/qtest/fuzz/i440fx_fuzz.c
> +++ b/tests/qtest/fuzz/i440fx_fuzz.c
> @@ -157,7 +157,7 @@ static void i440fx_fuzz_qos_fork(QTestState *s,
>   }
>   
>   static const char *i440fx_qtest_argv = TARGET_NAME " -machine accel=qtest"
> -                                       " -m 0 -display none";
> +                                       " -m 0";
>   static GString *i440fx_argv(FuzzTarget *t)
>   {
>       return g_string_new(i440fx_qtest_argv);
> diff --git a/tests/qtest/fuzz/qos_fuzz.c b/tests/qtest/fuzz/qos_fuzz.c
> index 3a3d9c16dd..fd431849a5 100644
> --- a/tests/qtest/fuzz/qos_fuzz.c
> +++ b/tests/qtest/fuzz/qos_fuzz.c
> @@ -85,7 +85,7 @@ static GString *qos_build_main_args(void)
>       }
>       /* Prepend the arguments that we need */
>       g_string_prepend(cmd_line,
> -            TARGET_NAME " -display none -machine accel=qtest -m 64 ");
> +            TARGET_NAME " -machine accel=qtest -m 64 ");
>       return cmd_line;
>   }
>   

This seems to break the build-oss-fuzz CI job:

 https://gitlab.com/thuth/qemu/-/jobs/3052856828#L3774

Please double-check whether it's ok to remove the "-display none" here.

 Thomas