Re: [PULL 00/12] linux-user patches

[Helge Deller]

On 9/17/22 22:11, Stefan Hajnoczi wrote:
> On Sat, 17 Sept 2022 at 15:31, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> > On 17/9/22 16:26, Stefan Hajnoczi wrote:
> > > The close_range(2) man page says:
> > > close_range() first appeared in Linux 5.9.  Library support was added
> > > in glibc in version 2.34.
> > >
> > > The qemu-user GitLab CI jobs are failing. For example, see
> > > https://gitlab.com/qemu-project/qemu/-/jobs/3043629417:
> > >
> > > ../linux-user/syscall.c:8734:26: error: implicit declaration of
> > > function 'close_range' is invalid in C99
> > > [-Werror,-Wimplicit-function-declaration]
> > > return get_errno(close_range(arg1, arg2, arg3));
> > >                              ^
> > >
> > > There is a second issue with this pull request:
> > > ../linux-user/syscall.c:357:16: error: ‘pidfd_getfd’ defined but not
> > > used [-Werror=unused-function]
> > > 357 | _syscall3(int, pidfd_getfd, int, pidfd, int, targetfd, unsigned
> > > int, flags);
> > >          | ^~~~~~~~~~~
> > > ../linux-user/syscall.c:251:13: note: in definition of macro ‘_syscall3’
> > >
> > > See https://gitlab.com/qemu-project/qemu/-/jobs/3043629434.

Stefan, Thanks for testing those patches!
I'll send a new series with those issues fixed soon.


> > Hmm apparently this PR hasn't been reviewed (although the patches were
> > on the list for 2 weeks).
> >
> > The 'check DCO' job - looking for S-o-b tags -  is green:
> > https://gitlab.com/qemu-project/qemu/-/jobs/3043629425.
> > Should we complete it by a R-b/A-b check over the commit range?
>
> In some areas there will be no R-b/A-b, so I don't think we can
> require those checks.
>
> Was this pull request supposed to go through Laurent instead of being
> applied directly by me?

I'm fine with either way :-)

Thanks!
Helge

Btw, I have a whole bunch of additional patches on top of this
series so it would be good to get this series in first...