qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] target/m68k: rename M68K_FEATURE_M68000 to M68K_FEATURE_


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 1/4] target/m68k: rename M68K_FEATURE_M68000 to M68K_FEATURE_M68K
Date: Sun, 18 Sep 2022 00:21:01 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 17/9/22 13:25, Mark Cave-Ayland wrote:
The M68K_FEATURE_M68000 feature is misleading in that its name suggests the 
feature
is defined just for Motorola 68000 CPUs, whilst in fact it is defined for all
Motorola 680X0 CPUs.

In order to avoid confusion with the other M68K_FEATURE_M680X0 constants which
define the features available for specific Motorola CPU models, rename
M68K_FEATURE_M68000 to M68K_FEATURE_M68K and add comments to clarify its usage.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
  target/m68k/cpu.c       |   2 +-
  target/m68k/cpu.h       |   5 +-
  target/m68k/helper.c    |   2 +-
  target/m68k/op_helper.c |   2 +-
  target/m68k/translate.c | 138 ++++++++++++++++++++--------------------
  5 files changed, 75 insertions(+), 74 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]