Re: [PATCH 09/27] qapi char: Elide redundant has_FOO in generated C

[Daniel P . Berrangé]

On Thu, Sep 15, 2022 at 10:42:59PM +0200, Markus Armbruster wrote:
> The has_FOO for pointer-valued FOO are redundant, except for arrays.
> They are also a nuisance to work with.  Recent commit "qapi: Start to
> elide redundant has_FOO in generated C" provided the means to elide
> them step by step.  This is the step for qapi/char.json.
> 
> Said commit explains the transformation in more detail.  The invariant
> violations mentioned there do not occur here.
> 
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  chardev/char-file.c    |  2 +-
>  chardev/char-socket.c  | 10 ++++------
>  chardev/char-udp.c     |  1 -
>  chardev/char.c         |  6 +-----
>  tests/unit/test-char.c |  1 -
>  scripts/qapi/schema.py |  1 -
>  6 files changed, 6 insertions(+), 15 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|