Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C

[Ani Sinha]

On Fri, Sep 16, 2022 at 1:48 PM Markus Armbruster <armbru@redhat.com> wrote:
>
> Ani Sinha <ani@anisinha.ca> writes:
>
> > On Fri, Sep 16, 2022 at 2:13 AM Markus Armbruster <armbru@redhat.com> wrote:
> >>
> >> The has_FOO for pointer-valued FOO are redundant, except for arrays.
> >> They are also a nuisance to work with.  Recent commit "qapi: Start to
> >> elide redundant has_FOO in generated C"
> >
> > Commit is referenced using <commit hash 13 chars min> ("commit header")
>
> Apply my patches in your tree, and your hashes will differ from mine.
> Hashes can serve as stable reference only when we git-fetch patches, not
> when we git-send-email then.

Has the referenced patch not been pushed upstream already? I thought
it was and hence was asking for the reference.

>
> >> provided the means to elide
> >> them step by step.  This is the step for qapi/acpi.py.
> >>
> >> Said commit explains the transformation in more detail.  The invariant
> >> violations mentioned there do not occur here.
> >>
> >> Cc: Michael S. Tsirkin <mst@redhat.com>
> >> Cc: Igor Mammedov <imammedo@redhat.com>
> >> Cc: Ani Sinha <ani@anisinha.ca>
> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>