[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 05/15] virtio: core: vq reset feature negotation support
From: |
Jason Wang |
Subject: |
Re: [PATCH v4 05/15] virtio: core: vq reset feature negotation support |
Date: |
Tue, 13 Sep 2022 13:56:58 +0800 |
On Mon, Sep 12, 2022 at 1:22 AM Kangjie Xu <kangjie.xu@linux.alibaba.com> wrote:
>
> A a new command line parameter "queue_reset" is added.
>
> Meanwhile, the vq reset feature is disabled for pre-7.2 machines.
>
> Signed-off-by: Kangjie Xu <kangjie.xu@linux.alibaba.com>
> Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> hw/core/machine.c | 4 +++-
> include/hw/virtio/virtio.h | 4 +++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index aa520e74a8..907fa78ff0 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -40,7 +40,9 @@
> #include "hw/virtio/virtio-pci.h"
> #include "qom/object_interfaces.h"
>
> -GlobalProperty hw_compat_7_1[] = {};
> +GlobalProperty hw_compat_7_1[] = {
> + { "virtio-device", "queue_reset", "false" },
> +};
> const size_t hw_compat_7_1_len = G_N_ELEMENTS(hw_compat_7_1);
>
> GlobalProperty hw_compat_7_0[] = {
> diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
> index 085997d8f3..ed3ecbef80 100644
> --- a/include/hw/virtio/virtio.h
> +++ b/include/hw/virtio/virtio.h
> @@ -295,7 +295,9 @@ typedef struct VirtIORNGConf VirtIORNGConf;
> DEFINE_PROP_BIT64("iommu_platform", _state, _field, \
> VIRTIO_F_IOMMU_PLATFORM, false), \
> DEFINE_PROP_BIT64("packed", _state, _field, \
> - VIRTIO_F_RING_PACKED, false)
> + VIRTIO_F_RING_PACKED, false), \
> + DEFINE_PROP_BIT64("queue_reset", _state, _field, \
> + VIRTIO_F_RING_RESET, true)
>
> hwaddr virtio_queue_get_desc_addr(VirtIODevice *vdev, int n);
> bool virtio_queue_enabled_legacy(VirtIODevice *vdev, int n);
> --
> 2.32.0
>
- [PATCH v4 01/15] virtio: sync relevant definitions with linux, (continued)
- [PATCH v4 01/15] virtio: sync relevant definitions with linux, Kangjie Xu, 2022/09/11
- [PATCH v4 10/15] vhost-net: vhost-kernel: introduce vhost_net_virtqueue_reset(), Kangjie Xu, 2022/09/11
- [PATCH v4 09/15] vhost: expose vhost_virtqueue_stop(), Kangjie Xu, 2022/09/11
- [PATCH v4 06/15] virtio-pci: support queue reset, Kangjie Xu, 2022/09/11
- [PATCH v4 15/15] vhost: vhost-kernel: enable vq reset feature, Kangjie Xu, 2022/09/11
- [PATCH v4 08/15] vhost: expose vhost_virtqueue_start(), Kangjie Xu, 2022/09/11
- [PATCH v4 05/15] virtio: core: vq reset feature negotation support, Kangjie Xu, 2022/09/11
- Re: [PATCH v4 05/15] virtio: core: vq reset feature negotation support,
Jason Wang <=
- [PATCH v4 11/15] vhost-net: vhost-kernel: introduce vhost_net_virtqueue_restart(), Kangjie Xu, 2022/09/11
- [PATCH v4 07/15] virtio-pci: support queue enable, Kangjie Xu, 2022/09/11
- [PATCH v4 03/15] virtio: introduce virtio_queue_reset(), Kangjie Xu, 2022/09/11
- [PATCH v4 13/15] virtio-net: support queue reset, Kangjie Xu, 2022/09/11
- [PATCH v4 12/15] virtio-net: introduce flush_or_purge_queued_packets(), Kangjie Xu, 2022/09/11
- [PATCH v4 14/15] virtio-net: support queue_enable, Kangjie Xu, 2022/09/11