[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/5] acpi/nvdimm: define macro for NVDIMM Device _DSM
From: |
Igor Mammedov |
Subject: |
Re: [PATCH v3 3/5] acpi/nvdimm: define macro for NVDIMM Device _DSM |
Date: |
Wed, 7 Sep 2022 11:15:38 +0200 |
On Thu, 1 Sep 2022 11:27:19 +0800
Robert Hoo <robert.hu@linux.intel.com> wrote:
> Since it will be heavily used in next patch, define macro
> NVDIMM_DEVICE_DSM_UUID for "4309AC30-0D11-11E4-9191-0800200C9A66", which is
> NVDIMM device specific method uuid defined in NVDIMM _DSM interface spec,
> Section 3. [1]
>
> No functional changes in this patch.
>
> [1] https://pmem.io/documents/IntelOptanePMem_DSM_Interface-V2.0.pdf
>
> Signed-off-by: Robert Hoo <robert.hu@linux.intel.com>
> Reviewed-by: Jingqi Liu <jingqi.liu@intel.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/acpi/nvdimm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
> index 201317c611..afff911c1e 100644
> --- a/hw/acpi/nvdimm.c
> +++ b/hw/acpi/nvdimm.c
> @@ -922,6 +922,7 @@ void nvdimm_init_acpi_state(NVDIMMState *state,
> MemoryRegion *io,
> #define NVDIMM_DSM_RFIT_STATUS "RSTA"
>
> #define NVDIMM_QEMU_RSVD_UUID "648B9CF2-CDA1-4312-8AD9-49C4AF32BD62"
> +#define NVDIMM_DEVICE_DSM_UUID "4309AC30-0D11-11E4-9191-0800200C9A66"
>
> static void nvdimm_build_common_dsm(Aml *dev,
> NVDIMMState *nvdimm_state)
> @@ -1029,8 +1030,7 @@ static void nvdimm_build_common_dsm(Aml *dev,
> /* UUID for QEMU internal use */), expected_uuid));
> aml_append(elsectx, ifctx);
> elsectx2 = aml_else();
> - aml_append(elsectx2, aml_store(
> - aml_touuid("4309AC30-0D11-11E4-9191-0800200C9A66")
> + aml_append(elsectx2, aml_store(aml_touuid(NVDIMM_DEVICE_DSM_UUID)
> /* UUID for NVDIMM Devices */, expected_uuid));
> aml_append(elsectx, elsectx2);
> aml_append(method, elsectx);
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v3 3/5] acpi/nvdimm: define macro for NVDIMM Device _DSM,
Igor Mammedov <=