Re: [PATCH 18/19] target/ppc: Clear fpstatus flags on VSX_CMP

[Víctor Colombo]

On 05/09/2022 15:41, Daniel Henrique Barboza wrote:
> On 9/1/22 10:17, Víctor Colombo wrote:
> > Signed-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>
> > ---
>
> What I mentioned in patch 10 also applies to all patches from 11 to 18
> it seems. All changes made in patches 09-18 are based on the explanation
> gave in patch 08.
>
> The problem with this is that it'll be annoying if/when something goes
> wrong. Let's say that the change made in patch 15 caused a side-effect.
> Bisect will point it to patch 15, which doesn't have an explanation of
> why you made the change, and then one will need to trace it back to the
> mailing list to understand it. It's not a given that one will look at
> all the recent changes and understand that the logic used in patch 08
> are also being used in the subsequent patches.
>
> I don't mind if you just copy/paste the commit message from patch 08 and
> just change the instruction name being fixed. What's important is to
> provide some context for each individual change.
>
>
> Thanks,
>
>
> Daniel

Hello Daniel. Thank you very much for the reviews.

I'll take your recommendation and make the necessary changes.

Best regards,

--
Víctor Cora Colombo
Instituto de Pesquisas ELDORADO
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>