qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 0/2] introduce qemu_socketpiar()


From: Marc-André Lureau
Subject: Re: [PATCH v1 0/2] introduce qemu_socketpiar()
Date: Mon, 5 Sep 2022 15:19:29 +0400

Hi

On Tue, Aug 23, 2022 at 12:00 PM <tugy@chinatelecom.cn> wrote:
From: Guoyi Tu <tugy@chinatelecom.cn>

Introduce qemu_socketpair() to create socket pair fd, and
set the close-on-exec flag at default as with the other type
of socket does.

besides, the live update feature is developing, so it's necessary
to do that.

Guoyi Tu (2):
  oslib-posix: Introduce qemu_socketpair()
  vhost-user: Call qemu_socketpair() instead of socketpair()

Looks like a good idea to me. We will eventually extend the support for win32 (as discussed in "[PATCH 19/51] tests/qtest: Build test-filter-{mirror, redirector} cases for posix only").

There are other places where you can replace existing socketpair() calls in the code base. Why not do it?

Current patches lgtm
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

--
Marc-André Lureau

reply via email to

[Prev in Thread] Current Thread [Next in Thread]