qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 03/20] disas/nanomips: Delete NMD class fields


From: Richard Henderson
Subject: Re: [PATCH v2 03/20] disas/nanomips: Delete NMD class fields
Date: Mon, 5 Sep 2022 12:04:36 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 9/5/22 10:55, Milica Lazarevic wrote:
Two class fields have been deleted.

Since the m_requested_instruction_categories field always has the same
value, which is ALL_ATTRIBUTES, the only use of that field has been
replaced with the concrete ALL_ATTRIBUTES value.

Since these ALL_ATTRIBUTES tests are always true, you could just remove them.


The second class field m_pc is added as a parameter where needed.
Therefore, prototypes of the following functions have been changed:
- public NMD::Disassemble method
- private NMD::Disassemble method
- NMD::ADDRESS method
- all of the disassembly_function methods

Accordingly, the disassembly_function typedef has been changed.

Fine.

These two changes should be done separately.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]