[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/11] target/openrisc: Fix memory reading in debugger
From: |
Stafford Horne |
Subject: |
[PULL 02/11] target/openrisc: Fix memory reading in debugger |
Date: |
Sun, 4 Sep 2022 08:25:58 +0100 |
In commit f0655423ca ("target/openrisc: Reorg tlb lookup") data and
instruction TLB reads were combined. This, broke debugger reads where
we first tried to map using the data tlb then fall back to the
instruction tlb.
This patch replicates this logic by first requesting a PAGE_READ
protection mapping then falling back to PAGE_EXEC.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
target/openrisc/mmu.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/target/openrisc/mmu.c b/target/openrisc/mmu.c
index d7e1320998..0b8afdbacf 100644
--- a/target/openrisc/mmu.c
+++ b/target/openrisc/mmu.c
@@ -148,7 +148,13 @@ hwaddr openrisc_cpu_get_phys_page_debug(CPUState *cs,
vaddr addr)
case SR_DME | SR_IME:
/* The mmu is definitely enabled. */
excp = get_phys_mmu(cpu, &phys_addr, &prot, addr,
- PAGE_EXEC | PAGE_READ | PAGE_WRITE,
+ PAGE_READ,
+ (sr & SR_SM) != 0);
+ if (!excp) {
+ return phys_addr;
+ }
+ excp = get_phys_mmu(cpu, &phys_addr, &prot, addr,
+ PAGE_EXEC,
(sr & SR_SM) != 0);
return excp ? -1 : phys_addr;
--
2.37.2
- [PULL 00/11] OpenRISC updates for 7.2.0, Stafford Horne, 2022/09/04
- [PULL 02/11] target/openrisc: Fix memory reading in debugger,
Stafford Horne <=
- [PULL 01/11] hw/openrisc: Split re-usable boot time apis out to boot.c, Stafford Horne, 2022/09/04
- [PULL 03/11] goldfish_rtc: Add big-endian property, Stafford Horne, 2022/09/04
- [PULL 04/11] hw/openrisc: Add the OpenRISC virtual machine, Stafford Horne, 2022/09/04
- [PULL 06/11] hw/openrisc: Initialize timer time at startup, Stafford Horne, 2022/09/04
- [PULL 05/11] hw/openrisc: Add PCI bus support to virt, Stafford Horne, 2022/09/04
- [PULL 08/11] target/openrisc: Enable MTTCG, Stafford Horne, 2022/09/04
- [PULL 07/11] target/openrisc: Add interrupted CPU to log, Stafford Horne, 2022/09/04
- [PULL 09/11] target/openrisc: Interrupt handling fixes, Stafford Horne, 2022/09/04
- [PULL 10/11] hw/openrisc: virt: pass random seed to fdt, Stafford Horne, 2022/09/04
- [PULL 11/11] docs/system: openrisc: Add OpenRISC documentation, Stafford Horne, 2022/09/04