[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/10] hw/arm/virt: Fix devicetree warnings about the SMMU no
From: |
Jean-Philippe Brucker |
Subject: |
Re: [PATCH 09/10] hw/arm/virt: Fix devicetree warnings about the SMMU node |
Date: |
Thu, 1 Sep 2022 16:01:18 +0100 |
On Wed, Aug 24, 2022 at 08:45:05PM +0100, Peter Maydell wrote:
> On Wed, 24 Aug 2022 at 16:51, Jean-Philippe Brucker
> <jean-philippe@linaro.org> wrote:
> >
> > dt-validate reports three issues in the SMMU device-tree node:
> >
> > smmuv3@9050000: $nodename:0: 'smmuv3@9050000' does not match
> > '^iommu@[0-9a-f]*'
> > smmuv3@9050000: interrupt-names: 'oneOf' conditional failed, one must be
> > fixed:
> > ['eventq', 'priq', 'cmdq-sync', 'gerror'] is too long
> > 'combined' was expected
> > 'gerror' was expected
> > 'gerror' is not one of ['cmdq-sync', 'priq']
> > smmuv3@9050000: 'clock-names', 'clocks' do not match any of the regexes:
> > 'pinctrl-[0-9]+'
> > From schema:
> > linux/Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml
> >
> > Fix them by:
> > * changing the node name
> > * reordering the IRQs
> > * removing the clock properties which are not expected for the SMMU node
>
> Why does dt-validate insist on a fixed interrupt order here?
I think the binding can be relaxed, since the driver must always look at
interrupt-names and can't assume a specific order (given that all except
gerror are now optional).
Thanks,
Jean
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 09/10] hw/arm/virt: Fix devicetree warnings about the SMMU node,
Jean-Philippe Brucker <=