[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: mark io-command test as skipped if socat is missing
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH] tests: mark io-command test as skipped if socat is missing |
|
Date: |
Thu, 1 Sep 2022 12:05:28 +0100 |
|
User-agent: |
Mutt/2.2.6 (2022-06-05) |
On Thu, Sep 01, 2022 at 03:04:14PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/unit/test-io-channel-command.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/unit/test-io-channel-command.c
> b/tests/unit/test-io-channel-command.c
> index 99056e07c0..aa09c559cd 100644
> --- a/tests/unit/test-io-channel-command.c
> +++ b/tests/unit/test-io-channel-command.c
> @@ -41,7 +41,8 @@ static void test_io_channel_command_fifo(bool async)
>
> unlink(TEST_FIFO);
> if (access("/bin/socat", X_OK) < 0) {
> - return; /* Pretend success if socat is not present */
> + g_test_skip("socat is missing");
> + return;
> }
> if (mkfifo(TEST_FIFO, 0600) < 0) {
> abort();
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|