[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 03/16] qapi: fix example of query-spice command
From: |
Victor Toso |
Subject: |
Re: [PATCH v1 03/16] qapi: fix example of query-spice command |
Date: |
Wed, 31 Aug 2022 14:55:05 +0200 |
Hi,
On Wed, Aug 31, 2022 at 01:50:31PM +0200, Markus Armbruster wrote:
> Victor Toso <victortoso@redhat.com> writes:
>
> > Example output has an extra ',' delimiter and a foreign comment
> > format. Fix it.
> >
> > Problem was noticed when trying to load the example into python's json
> > library.
> >
> > Signed-off-by: Victor Toso <victortoso@redhat.com>
> > ---
> > qapi/ui.json | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/qapi/ui.json b/qapi/ui.json
> > index 286c5731d1..901b84da8a 100644
> > --- a/qapi/ui.json
> > +++ b/qapi/ui.json
> > @@ -356,8 +356,7 @@
> > # "host": "127.0.0.1",
> > # "channel-id": 0,
> > # "tls": false
> > -# },
> > -# [ ... more channels follow ... ]
> > +# }
> > # ]
> > # }
> > # }
>
> Hmm. You're removing an ellipsis Gerd put there for a reason,
> I presume (commit cb42a870c3 "spice: add qmp 'query-spice' and
> hmp 'info spice' commands.")
I guess the reason is just that we get a too big array of
SpiceChannels so the example output would be big but not
interesting.
> Even if we can do without it here, We may still want a way to
> abridge examples. Thoughts?
I just want something that can be a valid QMP message so we can
transform JSON to a specific language type and then back to QMP
message and compare that both matches.
I don't think that, for the purpose of query-spice documentation
it is worth to have a very similar but with 10 or more entries of
array of channels. So, I'd say it is fine to simply cut it here.
If we have a reason to put it out a 100% valid message, well, we
would have that reason to back it up... but I don't have one.
Cheers,
Victor
signature.asc
Description: PGP signature
- [PATCH v1 00/16] qapi examples fixes and rfc for another generator, Victor Toso, 2022/08/30
- [PATCH v1 04/16] qapi: fix example of query-rocker-of-dpa-flows command, Victor Toso, 2022/08/30
- [PATCH v1 07/16] qapi: fix example of BLOCK_JOB_READY event, Victor Toso, 2022/08/30
- [PATCH v1 08/16] qapi: fix example of NIC_RX_FILTER_CHANGED event, Victor Toso, 2022/08/30
- [PATCH v1 09/16] qapi: fix example of DEVICE_UNPLUG_GUEST_ERROR event, Victor Toso, 2022/08/30
- [PATCH v1 06/16] qapi: fix example of query-blockstats command, Victor Toso, 2022/08/30
- [PATCH v1 11/16] qapi: fix examples of blockdev-add with qcow2, Victor Toso, 2022/08/30
- [PATCH v1 12/16] qapi: fix example of blockdev-add command, Victor Toso, 2022/08/30