qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/7] configure: fix misc shellcheck warnings


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 0/7] configure: fix misc shellcheck warnings
Date: Tue, 30 Aug 2022 14:16:23 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 25/8/22 17:06, Peter Maydell wrote:
Currently if you run shellcheck on our configure script it
generates a ton of warnings. This patchset fixes some of the
easier ones. I wasn't aiming for completeness or consistency;
I just wanted to zap some of the ones where the fix is clear
and didn't take long to write and is hopefully easy to review.
We can always come back and take another swing at it later.

thanks
-- PMM

Peter Maydell (7):
   configure: Remove unused python_version variable
   configure: Remove unused meson_args variable
   configure: Add missing quoting for some easy cases
   configure: Add './' on front of glob of */config-devices.mak.d
   configure: Remove use of backtick `...` syntax
   configure: Check mkdir result directly, not via $?
   configure: Avoid use of 'local' as it is non-POSIX

Series:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]