[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RFC 05/13] migration: Disallow postcopy preempt to be used with c
From: |
Peter Xu |
Subject: |
[PATCH RFC 05/13] migration: Disallow postcopy preempt to be used with compress |
Date: |
Mon, 29 Aug 2022 12:56:51 -0400 |
The preempt mode requires the capability to assign channel for each of the
page, while the compression logic will currently assign pages to different
compress thread/local-channel so potentially they're incompatible.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/migration.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index bb8bbddfe4..844bca1ff6 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1336,6 +1336,17 @@ static bool migrate_caps_check(bool *cap_list,
error_setg(errp, "Postcopy preempt requires postcopy-ram");
return false;
}
+
+ /*
+ * Preempt mode requires urgent pages to be sent in separate
+ * channel, OTOH compression logic will disorder all pages into
+ * different compression channels, which is not compatible with the
+ * preempt assumptions on channel assignments.
+ */
+ if (cap_list[MIGRATION_CAPABILITY_COMPRESS]) {
+ error_setg(errp, "Postcopy preempt not compatible with compress");
+ return false;
+ }
}
return true;
--
2.32.0
- [PATCH RFC 02/13] migration: Add postcopy_preempt_active(), (continued)
- [PATCH RFC 02/13] migration: Add postcopy_preempt_active(), Peter Xu, 2022/08/29
- [PATCH RFC 01/13] migration: Use non-atomic ops for clear log bitmap, Peter Xu, 2022/08/29
- [PATCH RFC 06/13] migration: Trivial cleanup save_page_header() on same block check, Peter Xu, 2022/08/29
- [PATCH RFC 07/13] migration: Remove RAMState.f references in compression code, Peter Xu, 2022/08/29
- [PATCH RFC 04/13] migration: Cleanup xbzrle zero page cache update logic, Peter Xu, 2022/08/29
- [PATCH RFC 11/13] migration: Make PageSearchStatus part of RAMState, Peter Xu, 2022/08/29
- [PATCH RFC 03/13] migration: Yield bitmap_mutex properly when sending/sleeping, Peter Xu, 2022/08/29
- [PATCH RFC 08/13] migration: Teach PSS about host page, Peter Xu, 2022/08/29
- [PATCH RFC 10/13] migration: Add pss_init(), Peter Xu, 2022/08/29
- [PATCH RFC 13/13] migration: Send requested page directly in rp-return thread, Peter Xu, 2022/08/29
- [PATCH RFC 05/13] migration: Disallow postcopy preempt to be used with compress,
Peter Xu <=
- [PATCH RFC 12/13] migration: Move last_sent_block into PageSearchStatus, Peter Xu, 2022/08/29
- [PATCH RFC 09/13] migration: Introduce pss_channel, Peter Xu, 2022/08/29
- Re: [PATCH RFC 00/13] migration: Postcopy Preempt-Full, Peter Xu, 2022/08/29