[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 11/10] parallels: Incorrect condition in out-of-image check
From: |
Alexander Ivanov |
Subject: |
[PATCH v6 11/10] parallels: Incorrect condition in out-of-image check |
Date: |
Fri, 26 Aug 2022 16:27:23 +0200 |
All the offsets in the BAT must be lower than the file size.
Fix the check condition for correct check.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index 8943eccbf5..e6e8b9e369 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -455,7 +455,7 @@ static int parallels_check_outside_image(BlockDriverState
*bs,
high_off = 0;
for (i = 0; i < s->bat_size; i++) {
off = bat2sect(s, i) << BDRV_SECTOR_BITS;
- if (off > size) {
+ if (off >= size) {
fprintf(stderr, "%s cluster %u is outside image\n",
fix & BDRV_FIX_ERRORS ? "Repairing" : "ERROR", i);
res->corruptions++;
--
2.34.1
- Re: [PATCH v6 07/10] parallels: Move check of cluster outside image to a separate function, (continued)
[PATCH v6 05/10] parallels: Use generic infrastructure for BAT writing in parallels_co_check(), Alexander Ivanov, 2022/08/25
[PATCH v6 08/10] parallels: Move check of leaks to a separate function, Alexander Ivanov, 2022/08/25
[PATCH v6 09/10] parallels: Move statistic collection to a separate function, Alexander Ivanov, 2022/08/25
[PATCH v6 03/10] parallels: Fix data_end after out-of-image check, Alexander Ivanov, 2022/08/25
[PATCH v6 10/10] parallels: Replace qemu_co_mutex_lock by WITH_QEMU_LOCK_GUARD, Alexander Ivanov, 2022/08/25
[PATCH v6 04/10] parallels: create parallels_set_bat_entry_helper() to assign BAT value, Alexander Ivanov, 2022/08/25
[PATCH v6 11/10] parallels: Incorrect condition in out-of-image check,
Alexander Ivanov <=
[PATCH v7 02/10] parallels: Fix high_off calculation in parallels_co_check(), Alexander Ivanov, 2022/08/29
- [PATCH v7 04/10] parallels: create parallels_set_bat_entry_helper() to assign BAT value, Alexander Ivanov, 2022/08/29
- [PATCH v7 03/10] parallels: Fix data_end after out-of-image check, Alexander Ivanov, 2022/08/29
- [PATCH v7 05/10] parallels: Use generic infrastructure for BAT writing in parallels_co_check(), Alexander Ivanov, 2022/08/29
- [PATCH v7 06/10] parallels: Move check of unclean image to a separate function, Alexander Ivanov, 2022/08/29
- [PATCH v7 11/10] parallels: Incorrect condition in out-of-image check, Alexander Ivanov, 2022/08/29
- [PATCH v7 07/10] parallels: Move check of cluster outside image to a separate function, Alexander Ivanov, 2022/08/29
- [PATCH v7 08/10] parallels: Move check of leaks to a separate function, Alexander Ivanov, 2022/08/29
- [PATCH v7 10/10] parallels: Replace qemu_co_mutex_lock by WITH_QEMU_LOCK_GUARD, Alexander Ivanov, 2022/08/29