Re: [PATCH 07/18] i386: Rewrite simple integer vector helpers

[Richard Henderson]

On 8/25/22 15:14, Paolo Bonzini wrote:
> +#define SSE_HELPER_2(name, elem, num, F)                        \
> +    void glue(name, SUFFIX)(CPUX86State *env, Reg *d, Reg *s)   \
> +    {                                                           \
> +       Reg *v = d;                                             \
> +        int n = num;                                            \

Indentation off.

> @@ -400,12 +373,19 @@ SSE_HELPER_W(helper_pcmpeqw, FCMPEQ)
>   SSE_HELPER_L(helper_pcmpeql, FCMPEQ)
>   
>   SSE_HELPER_W(helper_pmullw, FMULLW)
> -#if SHIFT == 0
> -SSE_HELPER_W(helper_pmulhrw, FMULHRW)
> -#endif
>   SSE_HELPER_W(helper_pmulhuw, FMULHUW)
>   SSE_HELPER_W(helper_pmulhw, FMULHW)
>   
> +#if SHIFT == 0
> +void glue(helper_pmulhrw, SUFFIX)(CPUX86State *env, Reg *d, Reg *s)
> +{
> +    d->W(0) = FMULHRW(d->W(0), s->W(0));
> +    d->W(1) = FMULHRW(d->W(1), s->W(1));
> +    d->W(2) = FMULHRW(d->W(2), s->W(2));
> +    d->W(3) = FMULHRW(d->W(3), s->W(3));
> +}
> +#endif

Why?

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~