[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 01/10] hw/arm/virt: Fix devicetree warning about the root node
From: |
Jean-Philippe Brucker |
Subject: |
[PATCH 01/10] hw/arm/virt: Fix devicetree warning about the root node |
Date: |
Wed, 24 Aug 2022 16:51:05 +0100 |
dt-validate warns that the 'model' property is missing from the
devicetree:
/: 'model' is a required property
From schema: dtschema/schemas/root-node.yaml
Use the same name for model as for compatible. The devicetree
specification recommends that 'compatible' follows the format
'manufacturer,model' and 'model' follows the format
'manufacturer,model-number'. Since our 'compatible' doesn't observe
this, 'model' doesn't really need to either.
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
---
This could be an opportunity to improve the machine print by Linux, for
example make it display "qemu,virt-7.2". I was concerned about breaking
some automated testing that may use the stable virt-x.y machines, so I
kept the same as compatible.
---
hw/arm/virt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 9633f822f3..abcf2716bc 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -252,6 +252,7 @@ static void create_fdt(VirtMachineState *vms)
qemu_fdt_setprop_string(fdt, "/", "compatible", "linux,dummy-virt");
qemu_fdt_setprop_cell(fdt, "/", "#address-cells", 0x2);
qemu_fdt_setprop_cell(fdt, "/", "#size-cells", 0x2);
+ qemu_fdt_setprop_string(fdt, "/", "model", "linux,dummy-virt");
/* /chosen must exist for load_dtb to fill in necessary properties later */
qemu_fdt_add_subnode(fdt, "/chosen");
--
2.37.1
- [PATCH 00/10] hw/arm/virt: Fix dt-schema warnings, Jean-Philippe Brucker, 2022/08/24
- [PATCH 01/10] hw/arm/virt: Fix devicetree warning about the root node,
Jean-Philippe Brucker <=
- [PATCH 06/10] hw/arm/virt: Fix devicetree warning about the gpio-key node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 02/10] hw/arm/boot: Fix devicetree warning about the PSCI node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 07/10] hw/arm/virt: Fix devicetree warnings about node names, Jean-Philippe Brucker, 2022/08/24
- [PATCH 03/10] hw/arm/virt: Fix devicetree warnings about the GIC node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 04/10] hw/arm/virt: Use "msi-map" devicetree property for PCI, Jean-Philippe Brucker, 2022/08/24
- [PATCH 05/10] hw/arm/virt: Fix devicetree warning about the timer node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 10/10] hw/arm/virt: Fix devicetree warnings about the virtio-iommu node, Jean-Philippe Brucker, 2022/08/24