Re: [PATCH 03/14] accel/tcg: Suppress auto-invalidate in probe_access_internal

[Richard Henderson]

On 8/23/22 08:19, Richard Henderson wrote:
> On 8/23/22 02:19, David Hildenbrand wrote:
> > 1) s390_probe_access() documents to "With nonfault=1, return the PGM_
> > exception that would have been injected into the guest; return 0 if no
> > exception was detected."
> >
> > But in case of CONFIG_USER_ONLY, we return the flags returned by
> > s390_probe_access(), not a PGM__* value. Maybe it doesn't matter,
> > because we'll simply inject a SIGSEGV in any case ...
>
> I would have said it would matter for MVPG, except that is incorrectly *not* marked as a 
> privileged instruction.  There should be no CONFIG_USER_ONLY case to answer there.

Ho hum, misread that -- only privileged if access key specified (and we do not check or 
support those).


r~