[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/10] target/arm: Implement FEAT_PMUv3p5 cycle counter disab
From: |
Peter Maydell |
Subject: |
Re: [PATCH 08/10] target/arm: Implement FEAT_PMUv3p5 cycle counter disable bits |
Date: |
Mon, 22 Aug 2022 09:56:32 +0100 |
On Sat, 20 Aug 2022 at 18:33, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 8/11/22 10:16, Peter Maydell wrote:
> > FEAT_PMUv3p5 introduces new bits MDCR_EL2.HCCD and MDCR_EL3.SCCD,
> > which disable the cycle counter from counting at EL2 and EL3.
> > Add the code to support these bits.
>
> While HCCD is v3p5, it seems MCCD (typo above) is v3p7.
DDI0487H.a page D13-6158 says
# SCCD, bit [23]
# When FEAT_PMUv3p5 is implemented:
# [...]
MDCR_EL3.MCCD is a different bit, bit 34, which is indeed v3p7.
It looks like I've got confused between the two and implemented
the wrong thing.
MDCR_EL3.SCCD: bit 23: v3p5: don't count in Secure state
MDCR_EL3.MCCD: bit 34: v3p7: don't count in EL3
and for completeness
MDCR_EL2.HCCD: bit 23: v3p5: don't count in EL2
I'll redo the patch to implement HCCD and SCCD. (We can leave
MCCD until we get to the PMUv3p7 feature.)
thanks
-- PMM
- [PATCH 01/10] target/arm: Don't corrupt high half of PMOVSR when cycle counter overflows, (continued)
- [PATCH 01/10] target/arm: Don't corrupt high half of PMOVSR when cycle counter overflows, Peter Maydell, 2022/08/11
- [PATCH 02/10] target/arm: Correct value returned by pmu_counter_mask(), Peter Maydell, 2022/08/11
- [PATCH 06/10] target/arm: Detect overflow when calculating next PMU interrupt, Peter Maydell, 2022/08/11
- [PATCH 03/10] target/arm: Don't mishandle count when enabling or disabling PMU counters, Peter Maydell, 2022/08/11
- [PATCH 08/10] target/arm: Implement FEAT_PMUv3p5 cycle counter disable bits, Peter Maydell, 2022/08/11
- [PATCH 05/10] target/arm: Honour MDCR_EL2.HPMD in Secure EL2, Peter Maydell, 2022/08/11
- [PATCH 04/10] target/arm: Ignore PMCR.D when PMCR.LC is set, Peter Maydell, 2022/08/11
- [PATCH 07/10] target/arm: Rename pmu_8_n feature test functions, Peter Maydell, 2022/08/11
- [PATCH 10/10] target/arm: Report FEAT_PMUv3p5 for TCG '-cpu max', Peter Maydell, 2022/08/11