[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/4] QEMU: Fix RISC-V virt & spike machines' dtbs
From: |
Alistair Francis |
Subject: |
Re: [PATCH v3 0/4] QEMU: Fix RISC-V virt & spike machines' dtbs |
Date: |
Mon, 22 Aug 2022 13:34:59 +1000 |
On Thu, Aug 11, 2022 at 5:09 AM Conor Dooley <mail@conchuod.ie> wrote:
>
> From: Conor Dooley <conor.dooley@microchip.com>
>
> The device trees produced automatically for the virt and spike machines
> fail dt-validate on several grounds. Some of these need to be fixed in
> the linux kernel's dt-bindings, but others are caused by bugs in QEMU.
>
> I mostly opted for what appeared to be the smallest change that would
> fix the warnings, partly due to my inexperience with the QEMU codebase.
> A "sister" patchset for the kernel will clear the remaining warnings.
> Thanks to Rob Herring for reporting these issues [1],
> Conor.
>
> Changes since v2:
> - move the syscon subnodes back to the top level instead of into the
> syscon node
> Changes since v1:
> - drop patch 1
>
> To reproduce the errors:
> ./build/qemu-system-riscv64 -nographic -machine virt,dumpdtb=qemu.dtb
> dt-validate -p
> /path/to/linux/kernel/Documentation/devicetree/bindings/processed-schema.json
> qemu.dtb
> (The processed schema needs to be generated first)
>
> 0 -
> https://lore.kernel.org/linux-riscv/20220805162844.1554247-1-mail@conchuod.ie/
> 1 -
> https://lore.kernel.org/linux-riscv/20220803170552.GA2250266-robh@kernel.org/
>
> Conor Dooley (4):
> hw/riscv: virt: fix uart node name
> hw/riscv: virt: fix the plic's address cells
> hw/riscv: virt: fix syscon subnode paths
> hw/core: fix platform bus node name
Thanks!
Applied to riscv-to-apply.next
Alistair
>
> hw/core/sysbus-fdt.c | 2 +-
> hw/riscv/virt.c | 8 +++++---
> include/hw/riscv/virt.h | 1 +
> 3 files changed, 7 insertions(+), 4 deletions(-)
>
>
> base-commit: 2480f3bbd03814b0651a1f74959f5c6631ee5819
> --
> 2.37.1
>
>