[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v9 03/12] vhost: Delete useless read memory barrier
From: |
Eugenio Pérez |
Subject: |
[PATCH v9 03/12] vhost: Delete useless read memory barrier |
Date: |
Fri, 19 Aug 2022 19:00:39 +0200 |
As discussed in previous series [1], this memory barrier is useless with
the atomic read of used idx at vhost_svq_more_used. Deleting it.
[1] https://lists.nongnu.org/archive/html/qemu-devel/2022-07/msg02616.html
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
---
hw/virtio/vhost-shadow-virtqueue.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/virtio/vhost-shadow-virtqueue.c
b/hw/virtio/vhost-shadow-virtqueue.c
index b35aeef4bd..8df5296f24 100644
--- a/hw/virtio/vhost-shadow-virtqueue.c
+++ b/hw/virtio/vhost-shadow-virtqueue.c
@@ -509,9 +509,6 @@ size_t vhost_svq_poll(VhostShadowVirtqueue *svq)
if (unlikely(g_get_monotonic_time() - start_us > 10e6)) {
return 0;
}
-
- /* Make sure we read new used_idx */
- smp_rmb();
} while (true);
}
--
2.31.1
- [PATCH v9 00/12] NIC vhost-vdpa state restore via Shadow CVQ, Eugenio Pérez, 2022/08/19
- [PATCH v9 01/12] vhost: stop transfer elem ownership in vhost_handle_guest_kick, Eugenio Pérez, 2022/08/19
- [PATCH v9 03/12] vhost: Delete useless read memory barrier,
Eugenio Pérez <=
- [PATCH v9 04/12] vhost: Do not depend on !NULL VirtQueueElement on vhost_svq_flush, Eugenio Pérez, 2022/08/19
- [PATCH v9 05/12] vhost_net: Add NetClientInfo start callback, Eugenio Pérez, 2022/08/19
- [PATCH v9 09/12] vdpa: extract vhost_vdpa_net_cvq_add from vhost_vdpa_net_handle_ctrl_avail, Eugenio Pérez, 2022/08/19
- [PATCH v9 06/12] vhost_net: Add NetClientInfo stop callback, Eugenio Pérez, 2022/08/19
- [PATCH v9 02/12] vhost: use SVQ element ndescs instead of opaque data for desc validation, Eugenio Pérez, 2022/08/19
- [PATCH v9 07/12] vdpa: add net_vhost_vdpa_cvq_info NetClientInfo, Eugenio Pérez, 2022/08/19
- [PATCH v9 08/12] vdpa: Move command buffers map to start of net device, Eugenio Pérez, 2022/08/19
- [PATCH v9 11/12] vdpa: Add virtio-net mac address via CVQ at start, Eugenio Pérez, 2022/08/19
- [PATCH v9 12/12] vdpa: Delete CVQ migration blocker, Eugenio Pérez, 2022/08/19