[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 11/11] tests/unit/test-vmstate: Avoid dynamic stack allocation
From: |
Peter Maydell |
Subject: |
[PATCH v2 11/11] tests/unit/test-vmstate: Avoid dynamic stack allocation |
Date: |
Fri, 19 Aug 2022 16:39:31 +0100 |
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Use autofree heap allocation instead of variable-length
array on the stack.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
tests/unit/test-vmstate.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tests/unit/test-vmstate.c b/tests/unit/test-vmstate.c
index 72077b57800..541bb4f63e3 100644
--- a/tests/unit/test-vmstate.c
+++ b/tests/unit/test-vmstate.c
@@ -87,17 +87,16 @@ static void save_buffer(const uint8_t *buf, size_t buf_size)
static void compare_vmstate(const uint8_t *wire, size_t size)
{
QEMUFile *f = open_test_file(false);
- uint8_t result[size];
+ g_autofree uint8_t *result = g_malloc(size);
/* read back as binary */
- g_assert_cmpint(qemu_get_buffer(f, result, sizeof(result)), ==,
- sizeof(result));
+ g_assert_cmpint(qemu_get_buffer(f, result, size), ==, size);
g_assert(!qemu_file_get_error(f));
/* Compare that what is on the file is the same that what we
expected to be there */
- SUCCESS(memcmp(result, wire, sizeof(result)));
+ SUCCESS(memcmp(result, wire, size));
/* Must reach EOF */
qemu_get_byte(f);
--
2.25.1
- [PATCH v2 03/11] chardev/baum: Avoid dynamic stack allocation, (continued)
- [PATCH v2 03/11] chardev/baum: Avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 04/11] io/channel-websock: Replace strlen(const_str) by sizeof(const_str) - 1, Peter Maydell, 2022/08/19
- [PATCH v2 02/11] chardev/baum: Use definitions to avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 01/11] chardev/baum: Replace magic values by X_MAX / Y_MAX definitions, Peter Maydell, 2022/08/19
- [PATCH v2 05/11] hw/net/e1000e_core: Use definition to avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 06/11] hw/ppc/pnv: Avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 07/11] hw/intc/xics: Avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 10/11] ui/curses: Avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 09/11] hw/usb/hcd-ohci: Use definition to avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 11/11] tests/unit/test-vmstate: Avoid dynamic stack allocation,
Peter Maydell <=
- [PATCH v2 08/11] hw/i386/multiboot: Avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- Re: [PATCH v2 00/11] misc: Remove variable-length arrays on the stack, Philippe Mathieu-Daudé, 2022/08/25