[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 0/4] linux-user: Fix siginfo_t contents when jumping to no
From: |
Ilya Leoshkevich |
Subject: |
Re: [PATCH v5 0/4] linux-user: Fix siginfo_t contents when jumping to non-readable pages |
Date: |
Wed, 17 Aug 2022 20:27:02 +0200 |
User-agent: |
Evolution 3.42.4 (3.42.4-2.fc35) |
On Wed, 2022-08-17 at 11:23 -0500, Richard Henderson wrote:
> On 8/17/22 10:05, Ilya Leoshkevich wrote:
> > Hi,
> >
> > I noticed that when we get a SEGV due to jumping to non-readable
> > memory, sometimes si_addr and program counter in siginfo_t are
> > slightly
> > off. I tracked this down to the assumption that translators stop
> > before
> > the end of a page, while in reality they may stop right after it.
> >
> > Patch 1 fixes an invalidation issue, which may prevent SEGV from
> > happening altogether.
> > Patches 2-3 fix the main issue on x86_64 and s390x. Many other
> > architectures have fixed-size instructions and are not affected.
> > Patch 4 adds tests.
> >
> > Note: this series depends on [1].
>
> Hah. I was just thinking that I should queue your patch set to tcg-
> next-7.2, and then
> rebase my stuff off of that. It would ensure that I have your test
> cases in tree so that
> I don't keep regressing them on you. :-)
>
> I'll cherry pick the one patch you're depending on.
>
>
> r~
I just checked and cherry-picking [1] and [2] before this series
should be enough.
[1] https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg02462.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg02461.html
- [PATCH v5 0/4] linux-user: Fix siginfo_t contents when jumping to non-readable pages, Ilya Leoshkevich, 2022/08/17
- [PATCH v5 2/4] target/s390x: Make translator stop before the end of a page, Ilya Leoshkevich, 2022/08/17
- [PATCH v5 1/4] linux-user: Clear tb_jmp_cache on mprotect(), Ilya Leoshkevich, 2022/08/17
- [PATCH v5 3/4] target/i386: Make translator stop before the end of a page, Ilya Leoshkevich, 2022/08/17
- [PATCH v5 4/4] tests/tcg: Test siginfo_t contents when jumping to non-readable pages, Ilya Leoshkevich, 2022/08/17
- Re: [PATCH v5 0/4] linux-user: Fix siginfo_t contents when jumping to non-readable pages, Richard Henderson, 2022/08/17
- Re: [PATCH v5 0/4] linux-user: Fix siginfo_t contents when jumping to non-readable pages,
Ilya Leoshkevich <=
- Re: [PATCH v5 0/4] linux-user: Fix siginfo_t contents when jumping to non-readable pages, Vivian Wang, 2022/08/18