qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] hw/net/can: fix Xilinx ZynqMP CAN RX FIFO logic


From: Peter Maydell
Subject: Re: [PATCH v2] hw/net/can: fix Xilinx ZynqMP CAN RX FIFO logic
Date: Wed, 17 Aug 2022 15:33:09 +0100

On Wed, 17 Aug 2022 at 15:24, Anton Kochkov <anton.kochkov@proton.me> wrote:
>
> For consistency, function "update_rx_fifo()" should use
> the RX FIFO register names, not the TX FIFO ones even if

"register field names"

> they refer to the same memory region.

"same bit positions in the register".

(No need to spin a v3 just for that; if there's no other
issues with the patch I'll fix it up when I take it into
target-arm.next.)

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]