[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ui/console: fix qemu_console_resize() regression
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH] ui/console: fix qemu_console_resize() regression |
Date: |
Tue, 16 Aug 2022 09:33:37 +0200 |
> > >> diff --git a/ui/console.c b/ui/console.c
> > >> index e139f7115e1f..765892f84f1c 100644
> > >> --- a/ui/console.c
> > >> +++ b/ui/console.c
> > >> @@ -2575,11 +2575,13 @@ static void vc_chr_open(Chardev *chr,
> > >> void qemu_console_resize(QemuConsole *s, int width, int height)
> > >> {
> > >> - DisplaySurface *surface;
> > >> + DisplaySurface *surface = qemu_console_surface(s);
> > >> assert(s->console_type == GRAPHIC_CONSOLE);
> > >> - if (qemu_console_get_width(s, -1) == width &&
> > >> + if ((s->scanout.kind != SCANOUT_SURFACE ||
> > >> + (surface && surface->flags & QEMU_ALLOCATED_FLAG)) &&
> > >> + qemu_console_get_width(s, -1) == width &&
> > >> qemu_console_get_height(s, -1) == height) {
> > >> return;
> > >> }
> Gerd, could you review the patch and let me send a MR ? (or do you
> have other UI patches queued already and take it?)
Patch looks good to me.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
[ just back from summer vacation, no pending queue atm, just started
walking through my email backlog though ... ]
take care,
Gerd