Re: [PATCH] [PATCH] linux-user/aarch64: Reset target data on MADV_DONTNEED

[Laurent Vivier]

Le 11/08/2022 à 17:18, Alex Bennée a écrit :
> Laurent Vivier <laurent@vivier.eu> writes:
>
> > Le 11/08/2022 à 13:54, Peter Maydell a écrit :
> > > On Thu, 11 Aug 2022 at 09:29, Laurent Vivier <laurent@vivier.eu> wrote:
> > > > Le 10/08/2022 à 22:47, Richard Henderson a écrit :
> > > > > On 8/10/22 13:32, Vitaly Buka wrote:
> > > > > > Sorry, I only noticed today that it's not submitted.
> > > > > > Version is not critical for us, as we build from masters anyway.
> > > > > > Richard, do you know a reason to consider this critical?
> > > > > >
> > > > > > On Wed, 10 Aug 2022 at 13:04, Peter Maydell <peter.maydell@linaro.org
> > > > > > <mailto:peter.maydell@linaro.org>> wrote:
> > > > > >
> > > > > >       On Wed, 10 Aug 2022 at 21:00, Vitaly Buka <vitalybuka@google.com
> > > > > >       <mailto:vitalybuka@google.com>> wrote:
> > > > > >        >
> > > > > >        > How can we land this one?
> > > > > >
> > > > > >       Pinging it a week ago rather than now would have been a good start :-(
> > > > > >       I think it got missed because you didn't cc the linux-user maintainer.
> > > > > >
> > > > > >       Is this a critical fix for 7.1 or can we let it slip to 7.2 ?
> > > > >
> > > > > It's unfortunate that it got missed.  It's not critical, but it would be nice, 
> > > > > because support for
> > > > > MADV_DONTNEED is new in 7.1 (previously, we ignored all madvise).
> > > > >
> > > > > I'll note there are missing braces for coding style on an IF.
> > > > >
> > > > > Laurent, do you have an objection to merging this for rc3?
> > > >
> > > > No objection.
> > > >
> > > > Do you want it goes via the arm branch or via the linux-user branch?
> > > >
> > > > If it goes via linux-user I can run the LTP testsuite but it takes 1 day.
> > > I think we should definitely run the LTP testsuite on it, so
> > > taking it via linux-user probably makes more sense.
> >
> > ok, applied to my linux-user-for-7.1 branch.
> >
> > Running tests.
>
> Any chance you could pick up:
>
>    Subject: [PATCH v2] linux-user: un-parent OBJECT(cpu) when closing thread
>    Date: Wed,  3 Aug 2022 14:05:37 +0100
>    Message-Id: <20220803130537.763666-1-alex.bennee@linaro.org>
>
> before you run the tests?

I've tested it, it works fine.

Do you plan to do a PR including it or do you want I do (there will be only 
this one in mine)?

Thanks,
Laurent