[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-7.1] tests: acpi: silence applesmc warning about invalid
From: |
Michael S. Tsirkin |
Subject: |
Re: [PATCH for-7.1] tests: acpi: silence applesmc warning about invalid key |
Date: |
Tue, 9 Aug 2022 07:42:54 -0400 |
On Tue, Aug 09, 2022 at 01:40:24PM +0200, Igor Mammedov wrote:
> On Thu, 28 Jul 2022 09:37:13 -0400
> Igor Mammedov <imammedo@redhat.com> wrote:
>
> > OSK value is irrelevant for ACPI test case.
> > Supply fake OSK explicitly to prevent QEMU complaining about
> > invalid key when it fallbacks to default_osk.
> >
> > Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>
> Michael,
> can you pick it up?
Yes! In the next pull. I was hoping the linux seed thing will
settle but apparently no luck ...
> > ---
> > tests/qtest/bios-tables-test.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> > index 359916c228..7c5f736b51 100644
> > --- a/tests/qtest/bios-tables-test.c
> > +++ b/tests/qtest/bios-tables-test.c
> > @@ -1632,7 +1632,9 @@ static void test_acpi_q35_applesmc(void)
> > .variant = ".applesmc",
> > };
> >
> > - test_acpi_one("-device isa-applesmc", &data);
> > + /* supply fake 64-byte OSK to silence missing key warning */
> > + test_acpi_one("-device isa-applesmc,osk=any64characterfakeoskisenough"
> > + "topreventinvalidkeywarningsonstderr", &data);
> > free_test_data(&data);
> > }
> >