|
From: | Cédric Le Goater |
Subject: | Re: [PATCH 07/19] ppc/ppc405: QOM'ify CPC |
Date: | Wed, 3 Aug 2022 11:16:31 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 |
On 8/3/22 11:14, Daniel Henrique Barboza wrote:
ppc_dcr_init(env, NULL, NULL); /* CPU control */ - ppc405ep_cpc_init(env, clk_setup, s->sysclk); + object_property_set_link(OBJECT(&s->cpc), "cpu", OBJECT(&s->cpu), + &error_abort); + if (!qdev_realize(DEVICE(&s->cpc), NULL, errp)) { + return; + }This if seems misaligned. Otherwise LGTM.
Indeed.
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Thanks, C.
[Prev in Thread] | Current Thread | [Next in Thread] |