qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] block/parallels: Fix buffer-based write call


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH 0/2] block/parallels: Fix buffer-based write call
Date: Tue, 26 Jul 2022 22:06:28 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1

On 7/14/22 16:27, Hanna Reitz wrote:
Hi,

While reviewing Stefan’s libblkio driver series, I’ve noticed that
block/parallels.c contains a call to bdrv_co_pwritev() that doesn’t pass
a QEMUIOVector object but a plain buffer instead.  That seems wrong and
also pretty dangerous, so change it to a bdrv_co_pwrite() call (as I
assume it should be), and add a regression test demonstrating the
problem.


Hanna Reitz (2):
   block/parallels: Fix buffer-based write call
   iotests/131: Add parallels regression test

  block/parallels.c          |  4 ++--
  tests/qemu-iotests/131     | 35 ++++++++++++++++++++++++++++++++++-
  tests/qemu-iotests/131.out | 13 +++++++++++++
  3 files changed, 49 insertions(+), 3 deletions(-)


Thanks, applied to my block branch.

--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]