[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/9] configure: Add missing POSIX-required space
From: |
Peter Maydell |
Subject: |
[PULL 4/9] configure: Add missing POSIX-required space |
Date: |
Tue, 26 Jul 2022 16:20:07 +0100 |
In commit 7d7dbf9dc15be6e1 we added a line to the configure script
which is not valid POSIX shell syntax, because it is missing a space
after a '!' character. shellcheck diagnoses this:
if !(GIT="$git" "$source_path/scripts/git-submodule.sh"
"$git_submodules_action" "$git_submodules"); then
^-- SC1035: You are missing a required space after the !.
and the OpenBSD shell will not correctly handle this without the space.
Fixes: 7d7dbf9dc15be6e1 ("configure: replace --enable/disable-git-update with
--with-git-submodules")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Tested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-id: 20220720152631.450903-2-peter.maydell@linaro.org
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 35e0b281985..dec6f030346 100755
--- a/configure
+++ b/configure
@@ -2425,7 +2425,7 @@ else
cxx=
fi
-if !(GIT="$git" "$source_path/scripts/git-submodule.sh"
"$git_submodules_action" "$git_submodules"); then
+if ! (GIT="$git" "$source_path/scripts/git-submodule.sh"
"$git_submodules_action" "$git_submodules"); then
exit 1
fi
--
2.25.1
- [PULL 5/9] target/arm: Move define_debug_regs() to debug_helper.c, (continued)
- [PULL 5/9] target/arm: Move define_debug_regs() to debug_helper.c, Peter Maydell, 2022/07/07
- [PULL 9/9] target/arm: Fix qemu-system-arm handling of LPAE block descriptors for highmem, Peter Maydell, 2022/07/07
- [PULL 8/9] target/arm: Correctly implement Feat_DoubleLock, Peter Maydell, 2022/07/07
- Re: [PULL 0/9] target-arm queue, Richard Henderson, 2022/07/07
- [PULL 0/9] target-arm queue, Peter Maydell, 2022/07/26
- [PULL 1/9] scripts/coverity-scan/COMPONENTS.md: Add loongarch component, Peter Maydell, 2022/07/26
- [PULL 2/9] scripts/coverity-scan/COMPONENTS.md: Update slirp component info, Peter Maydell, 2022/07/26
- [PULL 8/9] configure: Avoid '==' bashism, Peter Maydell, 2022/07/26
- [PULL 3/9] target/arm: Add MO_128 entry to pred_esz_masks[], Peter Maydell, 2022/07/26
- [PULL 7/9] configure: Drop dead code attempting to use -msmall-data on alpha hosts, Peter Maydell, 2022/07/26
- [PULL 4/9] configure: Add missing POSIX-required space,
Peter Maydell <=
- [PULL 5/9] configure: Add braces to clarify intent of $emu[[:space:]], Peter Maydell, 2022/07/26
- [PULL 6/9] configure: Don't use bash-specific string-replacement syntax, Peter Maydell, 2022/07/26
- [PULL 9/9] hw/display/bcm2835_fb: Fix framebuffer allocation address, Peter Maydell, 2022/07/26
- Re: [PULL 0/9] target-arm queue, Richard Henderson, 2022/07/26