Re: copy-before-write test failing

[Vladimir Sementsov-Ogievskiy]

On 7/6/22 19:22, Thomas Huth wrote:
> On 05/07/2022 11.03, Thomas Huth wrote:
> > On 14/06/2022 12.29, Vladimir Sementsov-Ogievskiy wrote:
> > > From: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
> > >
> > > Add two simple test-cases: timeout failure with
> > > break-snapshot-on-cbw-error behavior and similar with
> > > break-guest-write-on-cbw-error behavior.
> > >
> > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
> > > Reviewed-by: Hanna Reitz <hreitz@redhat.com>
> > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> > > ---
> > >   tests/qemu-iotests/tests/copy-before-write    | 81 +++++++++++++++++++
> > >   .../qemu-iotests/tests/copy-before-write.out  |  4 +-
> > >   2 files changed, 83 insertions(+), 2 deletions(-)
> >
> >   Hi!
> >
> > Seems like this test is failing in the CI on FreeBSD and macOS:
> >
> >   https://gitlab.com/qemu-project/qemu/-/jobs/2670729995#L5763
> >   https://gitlab.com/qemu-project/qemu/-/jobs/2670729993#L3247
> >
> > Could you please have a look?
>
> I just hit another failure, this time in a restricted build:
>
> +FFFF
> +======================================================================
> +FAIL: test_break_guest_write_on_cbw_error (__main__.TestCbwError)
> +break-guest-write behavior:
> +----------------------------------------------------------------------
> +Traceback (most recent call last):
> +  File "/home/thuth/devel/qemu/tests/qemu-iotests/tests/copy-before-write", 
> line 124, in test_break_guest_write_on_cbw_error
> +    log = self.do_cbw_error('break-guest-write')
> +  File "/home/thuth/devel/qemu/tests/qemu-iotests/tests/copy-before-write", 
> line 82, in do_cbw_error
> +    self.assert_qmp(result, 'return', {})
> +  File "/home/thuth/devel/qemu/tests/qemu-iotests/iotests.py", line 1190, in 
> assert_qmp
> +    result = self.dictpath(d, path)
> +  File "/home/thuth/devel/qemu/tests/qemu-iotests/iotests.py", line 1164, in 
> dictpath
> +    self.fail(f'failed path traversal for "{path}" in "{d}"')
> +AssertionError: failed path traversal for "return" in "{'error': {'class': 'GenericError', 
> 'desc': "Driver 'copy-before-write' is not whitelisted"}}"
>
> I think you need to check for the availability of the driver first, like it is 
> e.g. done in the image-fleecing test?

Oh, right!


--
Best regards,
Vladimir