[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 12/13] qemu-sockets: update socket_uri() to be consistent with
From: |
Laurent Vivier |
Subject: |
[PATCH v6 12/13] qemu-sockets: update socket_uri() to be consistent with socket_parse() |
Date: |
Wed, 6 Jul 2022 08:46:07 +0200 |
Remove 'tcp:' prefix for inet type (because inet can be 'tcp' or 'udp'
and socket_parse() doesn't recognize it), the format is 'host:port'.
Use 'vsock:' prefix for vsock type rather than 'tcp:' because it makes
a vsock address look like an inet address with CID misinterpreted as host.
Goes back to commit 9aca82ba31 "migration: Create socket-address parameter"
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
util/qemu-sockets.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index 870a36eb0e93..4cd76b3ae3af 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -1102,7 +1102,7 @@ char *socket_uri(SocketAddress *addr)
{
switch (addr->type) {
case SOCKET_ADDRESS_TYPE_INET:
- return g_strdup_printf("tcp:%s:%s",
+ return g_strdup_printf("%s:%s",
addr->u.inet.host,
addr->u.inet.port);
case SOCKET_ADDRESS_TYPE_UNIX:
@@ -1111,7 +1111,7 @@ char *socket_uri(SocketAddress *addr)
case SOCKET_ADDRESS_TYPE_FD:
return g_strdup_printf("fd:%s", addr->u.fd.str);
case SOCKET_ADDRESS_TYPE_VSOCK:
- return g_strdup_printf("tcp:%s:%s",
+ return g_strdup_printf("vsock:%s:%s",
addr->u.vsock.cid,
addr->u.vsock.port);
default:
--
2.36.1
- [PATCH v6 06/13] net: stream: Don't ignore EINVAL on netdev socket connection, (continued)
- [PATCH v6 06/13] net: stream: Don't ignore EINVAL on netdev socket connection, Laurent Vivier, 2022/07/06
- [PATCH v6 01/13] net: introduce convert_host_port(), Laurent Vivier, 2022/07/06
- [PATCH v6 04/13] qapi: net: introduce a way to bypass qemu_opts_parse_noisily(), Laurent Vivier, 2022/07/06
- [PATCH v6 05/13] qapi: net: add stream and dgram netdevs, Laurent Vivier, 2022/07/06
- [PATCH v6 08/13] net: dgram: make dgram_dst generic, Laurent Vivier, 2022/07/06
- [PATCH v6 02/13] net: remove the @errp argument of net_client_inits(), Laurent Vivier, 2022/07/06
- [PATCH v6 07/13] net: stream: add unix socket, Laurent Vivier, 2022/07/06
- [PATCH v6 10/13] net: dgram: add unix socket, Laurent Vivier, 2022/07/06
- [PATCH v6 09/13] net: dgram: move mcast specific code from net_socket_fd_init_dgram(), Laurent Vivier, 2022/07/06
- [PATCH v6 12/13] qemu-sockets: update socket_uri() to be consistent with socket_parse(),
Laurent Vivier <=
[PATCH v6 13/13] net: stream: move to QIO, Laurent Vivier, 2022/07/06
[PATCH v6 11/13] qemu-sockets: move and rename SocketAddress_to_str(), Laurent Vivier, 2022/07/06