Re: [PATCH v3 13/14] hw/misc/aspeed: Add intel-me

[Peter Delevoryas]

On Thu, Jun 30, 2022 at 01:09:09PM +0200, Cédric Le Goater wrote:
> On 6/30/22 06:51, Peter Delevoryas wrote:
> > From: Peter Delevoryas <pdel@fb.com>
> > 
> > The Intel Management Engine is an IPMI endpoint that responds to various
> > IPMI commands.
> 
> Have you looked at the ipmi-bmc-sim device ? It is relatively easy
> to attach to a bus.

No I haven't! I didn't realize there was already some ipmi simulation code,
that's great. I'll look into turning this into an ipmi-me-sim or something.

> 
> > In this commit, I've added some very basic functionality that
> > will respond back with a respond code of zero (success), while also setting
> > an appropriate response NetFN (request NetFN + 1), a matching command ID and
> > sequence number, and the 2 standard checksums. Other data is not provided,
> > but the model here could be extended to respond to more kinds of requests.
> > 
> > Signed-off-by: Peter Delevoryas <pdel@fb.com>
> > ---
> >   MAINTAINERS          |   1 +
> >   hw/misc/intel_me.c   | 162 +++++++++++++++++++++++++++++++++++++++++++
> >   hw/misc/meson.build  |   3 +-
> >   hw/misc/trace-events |   8 +++
> >   4 files changed, 173 insertions(+), 1 deletion(-)
> >   create mode 100644 hw/misc/intel_me.c
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 3ffd473db1..3220644bb5 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1068,6 +1068,7 @@ F: include/hw/net/ftgmac100.h
> >   F: docs/system/arm/aspeed.rst
> >   F: tests/qtest/*aspeed*
> >   F: hw/misc/fby35_sb_cpld.c
> > +F: hw/misc/intel_me.c
> >   NRF51
> >   M: Joel Stanley <joel@jms.id.au>
> > diff --git a/hw/misc/intel_me.c b/hw/misc/intel_me.c
> > new file mode 100644
> > index 0000000000..933ae45101
> > --- /dev/null
> > +++ b/hw/misc/intel_me.c
> > @@ -0,0 +1,162 @@
> > +/*
> > + * Copyright (c) Meta Platforms, Inc. and affiliates. (http://www.meta.com)
> > + *
> > + * This code is licensed under the GPL version 2 or later. See the COPYING
> > + * file in the top-level directory.
> > + */
> > +
> > +#include "qemu/osdep.h"
> > +#include "qemu/main-loop.h"
> > +#include "hw/i2c/i2c.h"
> > +#include "trace.h"
> > +
> > +#define TYPE_INTEL_ME "intel-me"
> > +OBJECT_DECLARE_SIMPLE_TYPE(IntelMEState, INTEL_ME);
> > +
> > +struct IntelMEState {
> > +    I2CSlave parent_obj;
> > +
> > +    I2CBus *bus;
> > +    QEMUBH *bh;
> > +    int rx_len;
> > +    int tx_len;
> > +    int tx_pos;
> > +    uint8_t rx_buf[512];
> > +    uint8_t tx_buf[512];
> > +};
> > +
> > +static void intel_me_bh(void *opaque)
> > +{
> > +    IntelMEState *s = opaque;
> > +    I2CSlave *i2c = I2C_SLAVE(s);
> > +    uint8_t target_addr;
> > +
> > +    assert(s->bus->bh == s->bh);
> > +
> > +    switch (s->tx_pos) {
> > +    case 0:
> > +        target_addr = s->tx_buf[s->tx_pos++];
> > +        trace_intel_me_tx_start(i2c->address, target_addr);
> > +        if (i2c_start_send_async(s->bus, target_addr) != 0) {
> > +            break;
> > +        }
> > +        return;
> > +    default:
> > +        if (s->tx_pos >= s->tx_len) {
> > +            break;
> > +        }
> > +        trace_intel_me_tx_data(i2c->address, s->tx_buf[s->tx_pos]);
> > +        if (i2c_send_async(s->bus, s->tx_buf[s->tx_pos++]) != 0) {
> > +            break;
> > +        }
> > +        return;
> > +    }
> > +
> > +    trace_intel_me_tx_end(i2c->address);
> > +    i2c_end_transfer(s->bus);
> > +    i2c_bus_release(s->bus);
> > +    s->tx_len = 0;
> > +    s->tx_pos = 0;
> > +    memset(s->tx_buf, 0, sizeof(s->tx_buf));
> > +}
> > +
> > +static void intel_me_realize(DeviceState *dev, Error **errp)
> > +{
> > +    IntelMEState *s = INTEL_ME(dev);
> > +
> > +    s->bus = I2C_BUS(qdev_get_parent_bus(dev));
> > +    s->bh = qemu_bh_new(intel_me_bh, s);
> > +    s->rx_len = 0;
> > +    s->tx_len = 0;
> > +    s->tx_pos = 0;
> > +    memset(s->rx_buf, 0, sizeof(s->rx_buf));
> > +    memset(s->tx_buf, 0, sizeof(s->tx_buf));
> > +}
> > +
> > +static uint8_t checksum(const uint8_t *ptr, int len)
> > +{
> > +    int sum = 0;
> > +
> > +    for (int i = 0; i < len; i++) {
> > +        sum += ptr[i];
> > +    }
> > +
> > +    return 256 - sum;
> > +}
> > +
> > +static int intel_me_i2c_event(I2CSlave *i2c, enum i2c_event event)
> > +{
> > +    IntelMEState *s = INTEL_ME(i2c);
> > +
> > +    switch (event) {
> > +    case I2C_START_RECV:
> > +        break;
> > +    case I2C_START_SEND:
> > +        trace_intel_me_rx_start(i2c->address);
> > +        s->rx_len = 0;
> > +        memset(s->rx_buf, 0, sizeof(s->rx_buf));
> > +        break;
> > +    case I2C_START_SEND_ASYNC:
> > +        break;
> > +    case I2C_FINISH:
> > +        trace_intel_me_rx_end(i2c->address);
> > +        s->tx_len = 10;
> > +        s->tx_pos = 0;
> > +        s->tx_buf[0] = s->rx_buf[2];
> > +        s->tx_buf[1] = ((s->rx_buf[0] >> 2) + 1) << 2;
> > +        s->tx_buf[2] = checksum(s->tx_buf, 2);
> > +        s->tx_buf[3] = i2c->address;
> > +        s->tx_buf[4] = (s->rx_buf[3] >> 2) << 2;
> > +        s->tx_buf[5] = s->rx_buf[4];
> > +        s->tx_buf[6] = 0x00;
> > +        s->tx_buf[7] = 0x55;
> > +        s->tx_buf[8] = 0x00;
> > +        s->tx_buf[9] = checksum(s->tx_buf, s->tx_len - 1);
> > +        s->tx_buf[0] >>= 1;
> > +        i2c_bus_master(s->bus, s->bh);
> > +        break;
> > +    case I2C_NACK:
> > +        break;
> > +    }
> > +
> > +    return 0;
> > +}
> > +
> > +static uint8_t intel_me_i2c_recv(I2CSlave *i2c)
> > +{
> > +    return 0xff;
> > +}
> > +
> > +static int intel_me_i2c_send(I2CSlave *i2c, uint8_t data)
> > +{
> > +    IntelMEState *s = INTEL_ME(i2c);
> > +
> > +    trace_intel_me_rx_data(i2c->address, data);
> > +
> > +    assert(s->rx_len < sizeof(s->rx_buf));
> > +    s->rx_buf[s->rx_len++] = data;
> > +
> > +    return 0;
> > +}
> > +
> > +static void intel_me_class_init(ObjectClass *oc, void *data)
> > +{
> > +    DeviceClass *dc = DEVICE_CLASS(oc);
> > +    I2CSlaveClass *i2c = I2C_SLAVE_CLASS(oc);
> > +
> > +    dc->realize = intel_me_realize;
> > +    i2c->event = intel_me_i2c_event;
> > +    i2c->recv = intel_me_i2c_recv;
> > +    i2c->send = intel_me_i2c_send;
> > +}
> > +
> > +static const TypeInfo types[] = {
> > +    {
> > +        .name = TYPE_INTEL_ME,
> > +        .parent = TYPE_I2C_SLAVE,
> > +        .instance_size = sizeof(IntelMEState),
> > +        .class_init = intel_me_class_init,
> > +    },
> > +};
> > +
> > +DEFINE_TYPES(types);
> > diff --git a/hw/misc/meson.build b/hw/misc/meson.build
> > index 948e25c440..165b9dce6d 100644
> > --- a/hw/misc/meson.build
> > +++ b/hw/misc/meson.build
> > @@ -118,7 +118,8 @@ softmmu_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: 
> > files(
> >     'aspeed_sdmc.c',
> >     'aspeed_xdma.c',
> >     'aspeed_peci.c',
> > -  'fby35_sb_cpld.c'))
> > +  'fby35_sb_cpld.c',
> > +  'intel_me.c'))
> >   softmmu_ss.add(when: 'CONFIG_MSF2', if_true: files('msf2-sysreg.c'))
> >   softmmu_ss.add(when: 'CONFIG_NRF51_SOC', if_true: files('nrf51_rng.c'))
> > diff --git a/hw/misc/trace-events b/hw/misc/trace-events
> > index 90a0473b06..7ca23bcf27 100644
> > --- a/hw/misc/trace-events
> > +++ b/hw/misc/trace-events
> > @@ -273,3 +273,11 @@ virt_ctrl_instance_init(void *dev) "ctrl: %p"
> >   lasi_chip_mem_valid(uint64_t addr, uint32_t val) "access to addr 
> > 0x%"PRIx64" is %d"
> >   lasi_chip_read(uint64_t addr, uint32_t val) "addr 0x%"PRIx64" val 0x%08x"
> >   lasi_chip_write(uint64_t addr, uint32_t val) "addr 0x%"PRIx64" val 0x%08x"
> > +
> > +# intel_me.c
> > +intel_me_rx_start(uint8_t addr) "addr 0x%02x"
> > +intel_me_rx_data(uint8_t addr, uint8_t data) "addr 0x%02x data 0x%02x"
> > +intel_me_rx_end(uint8_t addr) "addr 0x%02x"
> > +intel_me_tx_start(uint8_t addr, uint8_t target_addr) "addr 0x%02x 
> > target_addr 0x%02x"
> > +intel_me_tx_data(uint8_t addr, uint8_t data) "addr 0x%02x data 0x%02x"
> > +intel_me_tx_end(uint8_t addr) "addr 0x%02x"
>