[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] tcg: Fix returned type in alloc_code_gen_buffer_splitwx_memfd()
From: |
Shaobo Song |
Subject: |
[PATCH] tcg: Fix returned type in alloc_code_gen_buffer_splitwx_memfd() |
Date: |
Fri, 24 Jun 2022 23:02:17 +0800 |
This fixes a bug in POSIX-compliant environments. Since we had allocated
a buffer named 'tcg-jit' with read-write access protections we need a int
type to combine these access flags and return it, whereas we had inexplicably
return a bool type. It may cause an unnecessary protection change in
tcg_region_init().
Signed-off-by: Shaobo Song <shnusongshaobo@gmail.com>
---
tcg/region.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/region.c b/tcg/region.c
index 71ea81d671..88d6bb273f 100644
--- a/tcg/region.c
+++ b/tcg/region.c
@@ -548,7 +548,7 @@ static int alloc_code_gen_buffer_anon(size_t size, int prot,
#ifdef CONFIG_POSIX
#include "qemu/memfd.h"
-static bool alloc_code_gen_buffer_splitwx_memfd(size_t size, Error **errp)
+static int alloc_code_gen_buffer_splitwx_memfd(size_t size, Error **errp)
{
void *buf_rw = NULL, *buf_rx = MAP_FAILED;
int fd = -1;
--
2.25.1
- [PATCH] tcg: Fix returned type in alloc_code_gen_buffer_splitwx_memfd(),
Shaobo Song <=