[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 33/51] target/arm: Implement SME integer outer product
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 33/51] target/arm: Implement SME integer outer product |
Date: |
Fri, 24 Jun 2022 13:39:50 +0100 |
On Mon, 20 Jun 2022 at 19:29, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> This is SMOPA, SUMOPA, USMOPA_s, UMOPA, for both Int8 and Int16.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/helper-sme.h | 16 ++++++++
> target/arm/sme.decode | 10 +++++
> target/arm/sme_helper.c | 82 ++++++++++++++++++++++++++++++++++++++
> target/arm/translate-sme.c | 14 +++++++
> 4 files changed, 122 insertions(+)
> /* TODO: FEAT_EBF16 */
> TRANS_FEAT(BFMOPA, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_bfmopa)
> +
> +TRANS_FEAT(SMOPA_s, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_smopa_s)
> +TRANS_FEAT(UMOPA_s, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_umopa_s)
> +TRANS_FEAT(SUMOPA_s, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_sumopa_s)
> +TRANS_FEAT(USMOPA_s, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_usmopa_s)
> +
> +TRANS_FEAT(SMOPA_d, aa64_sme_i16i64, do_outprod,
> + a, MO_64, gen_helper_sme_smopa_d)
> +TRANS_FEAT(UMOPA_d, aa64_sme_i16i64, do_outprod,
> + a, MO_64, gen_helper_sme_umopa_d)
> +TRANS_FEAT(SUMOPA_d, aa64_sme_i16i64, do_outprod,
> + a, MO_64, gen_helper_sme_sumopa_d)
> +TRANS_FEAT(USMOPA_d, aa64_sme_i16i64, do_outprod,
> + a, MO_64, gen_helper_sme_usmopa_d)
I think this is one of those places where I'd say that wrapping the
lines reads worse than not wrapping them. But either way
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v3 29/51] target/arm: Implement SME ADDHA, ADDVA, (continued)
- [PATCH v3 29/51] target/arm: Implement SME ADDHA, ADDVA, Richard Henderson, 2022/06/20
- [PATCH v3 32/51] target/arm: Implement FMOPA, FMOPS (widening), Richard Henderson, 2022/06/20
- [PATCH v3 34/51] target/arm: Implement PSEL, Richard Henderson, 2022/06/20
- [PATCH v3 35/51] target/arm: Implement REVD, Richard Henderson, 2022/06/20
- [PATCH v3 38/51] target/arm: Enable SME for -cpu max, Richard Henderson, 2022/06/20
- [PATCH v3 30/51] target/arm: Implement FMOPA, FMOPS (non-widening), Richard Henderson, 2022/06/20
- [PATCH v3 37/51] target/arm: Reset streaming sve state on exception boundaries, Richard Henderson, 2022/06/20
- [PATCH v3 33/51] target/arm: Implement SME integer outer product, Richard Henderson, 2022/06/20
- Re: [PATCH v3 33/51] target/arm: Implement SME integer outer product,
Peter Maydell <=
- [PATCH v3 44/51] linux-user/aarch64: Verify extra record lock succeeded, Richard Henderson, 2022/06/20
- [PATCH v3 41/51] linux-user/aarch64: Add SM bit to SVE signal context, Richard Henderson, 2022/06/20
- [PATCH v3 43/51] linux-user/aarch64: Do not allow duplicate or short sve records, Richard Henderson, 2022/06/20
- [PATCH v3 47/51] linux-user: Rename sve prctls, Richard Henderson, 2022/06/20
- [PATCH v3 40/51] linux-user/aarch64: Reset PSTATE.SM on syscalls, Richard Henderson, 2022/06/20
- [PATCH v3 45/51] linux-user/aarch64: Move sve record checks into restore, Richard Henderson, 2022/06/20
- [PATCH v3 42/51] linux-user/aarch64: Tidy target_restore_sigframe error return, Richard Henderson, 2022/06/20
- [PATCH v3 50/51] target/arm: Enable SME for user-only, Richard Henderson, 2022/06/20
- [PATCH v3 46/51] linux-user/aarch64: Implement SME signal handling, Richard Henderson, 2022/06/20
- [PATCH v3 48/51] linux-user/aarch64: Implement PR_SME_GET_VL, PR_SME_SET_VL, Richard Henderson, 2022/06/20