[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v19 02/13] linux-user: Add LoongArch signal support
From: |
maobibo |
Subject: |
Re: [PATCH v19 02/13] linux-user: Add LoongArch signal support |
Date: |
Fri, 24 Jun 2022 08:45:55 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 |
在 2022/6/24 07:34, Richard Henderson 写道:
> On 6/23/22 01:55, Song Gao wrote:
>> +static void setup_sigcontext(CPULoongArchState *env,
>> + struct target_sigcontext *sc,
>> + struct extctx_layout *extctx)
>> +{
>> + int i;
>> +
>> + if (extctx->flags & SC_USED_FP) {
>> + __put_user(extctx->fpu.addr, &sc->sc_extcontext[0]);
>> + } else {
>> + __put_user(extctx->end.addr, &sc->sc_extcontext[0]);
>> + }
>
> This is incorrect. Where did this come from? It certainly doesn't appear in
> the kernel's version of setup_sigcontext. The only reason the result works
> for you is that this is overwritten by copy_fpu_to_sigframe within
> setup_sigframe.
The val of flags is SC_USED_FP alway in function setup_extcontext in this
version. We want to optimization in future if FP is not used for application
where sigcontext for FP is not necessary. Also it can will be extended for
128bit/256bit vector FPU.
regards
bibo,mao
>
>
> r~
[PATCH v19 05/13] linux-user: Add LoongArch cpu_loop support, Song Gao, 2022/06/23
[PATCH v19 04/13] linux-user: Add LoongArch syscall support, Song Gao, 2022/06/23
[PATCH v19 06/13] scripts: add loongarch64 binfmt config, Song Gao, 2022/06/23
[PATCH v19 09/13] target/loongarch: Fix helper_asrtle_d/asrtgt_d raise wrong exception, Song Gao, 2022/06/23
[PATCH v19 03/13] linux-user: Add LoongArch elf support, Song Gao, 2022/06/23
[PATCH v19 08/13] target/loongarch: Fix missing update CSR_BADV, Song Gao, 2022/06/23
[PATCH v19 13/13] target/loongarch: Update README, Song Gao, 2022/06/23